Skip to content

Commit df27638

Browse files
committed
react-material: Fix oneOf renderer not clearing some primitive values
Replace isEmpty check with check against undefined because isEmpty always returns true for boolean values, 0, empty strings and objects without props. This could lead to errors when switching from any of these to an array and trying to add elements there.
1 parent 961363d commit df27638

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/material-renderers/src/complex/MaterialOneOfRenderer.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
THE SOFTWARE.
2424
*/
2525
import React, { useCallback, useMemo, useState } from 'react';
26-
import isEmpty from 'lodash/isEmpty';
2726

2827
import { TabSwitchConfirmDialog } from './TabSwitchConfirmDialog';
2928

@@ -98,7 +97,7 @@ export const MaterialOneOfRenderer = ({
9897
const handleTabChange = useCallback(
9998
(_event: any, newOneOfIndex: number) => {
10099
setNewSelectedIndex(newOneOfIndex);
101-
if (isEmpty(data)) {
100+
if (data === undefined) {
102101
openNewTab(newOneOfIndex);
103102
} else {
104103
setConfirmDialogOpen(true);

0 commit comments

Comments
 (0)