deps: Update to Vuetify ^3.9 and Vue ^3.5#2468
Merged
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0b0d38a to
09e4bf1
Compare
- Update to latest Vuetify 3.9.0 - Update to latest Vue 3.5.17 - Update Vue peer dependency to ^3.5.0 - Update Vite to latest 5.x version ^5.4.19 - Fix imports for Vuetify promoted from labs - Fix typings for update events in Vuetify DateControlRenderer - Regenerate Vuetify test snapshots to fit changes in Vuetify (e.g. setting values in HTML element) - Add visualViewport mock for Vuetify tests as this seems to be needed after dependency update - In JsonForms.vue explicitly type provided state as `JsonFormsSubStates` to avoid TS7056
09e4bf1 to
cfeca5a
Compare
sdirix
requested changes
Jul 22, 2025
Member
sdirix
left a comment
There was a problem hiding this comment.
I can successfully build and use the Vue Vuetify demo application. However it breaks for me for the components which were moved from lab to the regular lib. Likely they changed behavior a bit.
auto close on minute/second selection. No longer closes on day selection as there is not event for day selection
Contributor
Author
|
Hi @sdirix , thanks for the review and valuable feedback. I adapted the following renderers:
|
Also adapts the numbers example to use a step with scientific notation number
94f6309 to
b2dfc6c
Compare
sdirix
approved these changes
Aug 1, 2025
Member
sdirix
left a comment
There was a problem hiding this comment.
All reported regressions are fixed 👍 Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonFormsSubStatesto avoid TS7056