Add a hook to get early access to trace object before loading#169
Merged
Conversation
Perfetto plugins in host apps need to be able to access contextual information associated with the trace during loading of the trace and initialization of the plugin instance. This requires that a host app be able to associate information with the trace before the AppImpl's promise result from its various trace loading APIs is resolved at the completion of loading. Accordingly, add an optinoal call-back function parameter to the AppImpl load method implementations to provide this trace early access hook. For android-graphics/sokatoa#4633 Signed-off-by: Christian W. Damus <cdamus@eclipsesource.com>
colin-grant-work
approved these changes
Feb 23, 2026
Collaborator
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Repeating the comment everywhere is likely the only way to get it to show on all call sites, but if it's for internal use, it may be overkill.
Collaborator
Author
Yeah this was a deliberate choice, a 🚨 to developers to make it clear that this is not an API for general use ◡̈ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfetto plugins in host apps need to be able to access contextual information associated with the trace during loading of the trace and initialization of the plugin instance. This requires that a host app be able to associate information with the trace before the AppImpl's promise result from its various trace loading APIs is resolved at the completion of loading. Accordingly, add an optinoal call-back function parameter to the AppImpl load method implementations to provide this trace early access hook.
For android-graphics/sokatoa#4633