fix last issue

Author: eclipsevortex

subvortex/core/model/neuron/model_neuron_210.py

@@ -54,8 +54,8 @@ async def write_all(self, redis: Redis, neurons: list[Neuron]):
                 pipe.hmset(key, data)
             await pipe.execute()
 
-    async def delete(self, redis: Redis, hotkey: str):
-        key = self._key(hotkey)
+    async def delete(self, redis: Redis, neuron: Neuron):
+        key = self._key(neuron.hotkey)
         await redis.delete(key)
 
     async def delete_all(self, redis: Redis, neurons: list[Neuron]):

subvortex/validator/neuron/src/miner.py

@@ -72,17 +72,26 @@ async def sync_miners(
         # Check if the miner did not exist
         if current_miner is None:
             # Create the new miner
-            miner = Miner.create_new_miner(
+            current_miner = Miner.create_new_miner(
                 uid=neuron.uid,
             )
+        elif current_miner.hotkey != hotkey:
+            # Remove the old miner
+            await database.remove_miner(miner=current_miner)
 
-            # Add the new miner
-            await database.add_miner(miner)
+            # Reset the updated miner
+            current_miner.reset()
 
-            # Add the new miner to the list
-            miners.append(miner)
+            # Log the success
+            btul.logging.success(
+                f"[{current_miner.uid}] New miner {hotkey} added to the list"
+            )
 
-            continue
+        # Check if the miner has changed localisation
+        if current_miner.ip != neuron.ip:
+            btul.logging.success(
+                f"[{current_miner.uid}] Miner moved from {current_miner.ip} to {neuron.ip}"
+            )
 
         # Create an updated miner
         miner = current_miner.clone()
@@ -97,26 +106,6 @@ async def sync_miners(
         miner.placeholder1 = neuron.placeholder1
         miner.placeholder2 = neuron.placeholder2
 
-        # Check if the miner has changed ownership
-        if current_miner.hotkey != hotkey:
-            # Remove the old miner
-            await database.remove_miner(miner=miner)
-
-            # Reset the updated miner
-            miner.reset()
-
-            # Add the new miner
-            await database.add_miner(miner=miner)
-
-            # Log the success
-            btul.logging.success(f"[{miner.uid}] New miner {hotkey} added to the list")
-
-        # Check if the miner has changed localisation
-        if current_miner.ip != neuron.ip:
-            btul.logging.success(
-                f"[{miner.uid}] Miner moved from {miner} to {neuron.ip}"
-            )
-
         miners_updates.append(miner)
 
     # Define the ip occurences

subvortex/validator/neuron/src/models/miner/model_miner_210.py

@@ -73,9 +73,9 @@ async def write_all(self, redis: Redis, miners: list[Miner]):
 
         await pipe.execute()
 
-    async def delete(self, redis: Redis, ss58_address: str):
+    async def delete(self, redis: Redis, miner: Miner):
         """
         Delete the statistics entry for a given hotkey.
         """
-        key = self._key(ss58_address)
+        key = self._key(miner.hotkey)
         await redis.delete(key)

subvortex/validator/neuron/tests/src/test_miner.py

@@ -54,11 +54,11 @@ async def test_sync_miners_adds_missing_miners():
     validator = fake_neuron(999, country="US")
     locations = ["US", "CA"]
 
-    await sync_miners(db, neurons, miners, validator, locations)
+    result = await sync_miners(db, neurons, miners, validator, locations)
 
-    assert len(miners) == 1
-    assert miners[0].uid == 1
-    db.add_miner.assert_called_once()
+    assert len(result) == 1
+    assert result[0].uid == 1
+    # db.add_miner.assert_called_once()
 
 
 @pytest.mark.asyncio
@@ -73,7 +73,6 @@ async def test_sync_miners_handles_hotkey_change():
     await sync_miners(db, neurons, miners, validator, locations)
 
     db.remove_miner.assert_called_once()
-    db.add_miner.assert_called()
 
 
 @pytest.mark.asyncio