Add default initialisation to MEMBER_LBOUNDS in FIELD_STACK#150
Merged
Conversation
e965033 to
c6039d9
Compare
Collaborator
|
Thanks a lot @wertysas for finding this subtle bug 🙏 As discussed offline, the gpu test was redundant since this is a field initialisation bug, and is independent of the offload status. |
dareg
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds default initialisation of the
MEMBER_LBOUNDSthat is used to define theLBOUNDSof the stack members, ensuring they are always set to1if noMEMBER_LBOUNDSargument is passed when creating the map.This is a small "bugfix-PR" and the only additions are the default initilisation lines in the field stack wrapper and owner FIELD_NEW methods and the field stack tests have been updated to cover this default behaviour.
Contributor Declaration
By opening this pull request, I affirm the following: