Skip to content

Add default initialisation to MEMBER_LBOUNDS in FIELD_STACK#150

Merged
awnawab merged 2 commits into
mainfrom
je-field-stack-member-lbound-fix
May 27, 2026
Merged

Add default initialisation to MEMBER_LBOUNDS in FIELD_STACK#150
awnawab merged 2 commits into
mainfrom
je-field-stack-member-lbound-fix

Conversation

@wertysas
Copy link
Copy Markdown
Contributor

This PR adds default initialisation of the MEMBER_LBOUNDS that is used to define the LBOUNDS of the stack members, ensuring they are always set to 1 if no MEMBER_LBOUNDS argument is passed when creating the map.

This is a small "bugfix-PR" and the only additions are the default initilisation lines in the field stack wrapper and owner FIELD_NEW methods and the field stack tests have been updated to cover this default behaviour.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@wertysas wertysas requested a review from awnawab May 19, 2026 12:59
@awnawab awnawab force-pushed the je-field-stack-member-lbound-fix branch from e965033 to c6039d9 Compare May 19, 2026 13:45
@awnawab
Copy link
Copy Markdown
Collaborator

awnawab commented May 19, 2026

Thanks a lot @wertysas for finding this subtle bug 🙏 As discussed offline, the gpu test was redundant since this is a field initialisation bug, and is independent of the offload status.

@awnawab awnawab self-assigned this May 19, 2026
@awnawab awnawab requested a review from dareg May 19, 2026 13:47
@awnawab awnawab merged commit 59b9601 into main May 27, 2026
130 of 131 checks passed
@awnawab awnawab deleted the je-field-stack-member-lbound-fix branch May 27, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants