Improve ASSOCIATE handling#664
Open
marsdeno wants to merge 1 commit into
Open
Conversation
* handle associations in intrinsic calls * add a direct command-line demonstration of in-place ASSOCIATE removal
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 96.39% 96.39% -0.01%
==========================================
Files 266 266
Lines 46418 46595 +177
==========================================
+ Hits 44745 44915 +170
- Misses 1673 1680 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IFS fortran code base makes heavy, structural use of
ASSOCIATEstatements.In many subroutines, nested
ASSOCIATEstatements can be found, and some cases of deep nests exist.This PR improves handling of
ASSOCIATEremoval, in particular by correctly resolving associated variables in calls to intrinsic functions, such as PRINT and WRITE.Given the prevalence of
ASSOCIATEusage, this PR also provides an easy-to-use option for resolving associates in a single file. This option can be invoked as follows :loki-transform.py convert --source nested_example.F90 --ass-wipeAn example of this is provided below.
cat nested_example.F90
The result of launching
loki-transform.py convert --source nested_example.F90 --ass-wipeis a correctly modified
nested_example.F90, along with the following output: