DeepcopyDataflowAnalysis: make sure disabled calls do not cause issues#697
Draft
MichaelSt98 wants to merge 1 commit into
Draft
DeepcopyDataflowAnalysis: make sure disabled calls do not cause issues#697MichaelSt98 wants to merge 1 commit into
MichaelSt98 wants to merge 1 commit into
Conversation
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/697/index.html |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 96.41% 94.21% -2.21%
==========================================
Files 284 288 +4
Lines 47492 47662 +170
==========================================
- Hits 45791 44904 -887
- Misses 1701 2758 +1057
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for disabling certain calls from being processed during the data offload deepcopy analysis, based on configurable pattern matching. The main changes introduce a mechanism to skip analysis for calls (such as error handler replacements) that match user-specified patterns, and include a new test to validate this behavior.
Dataflow Analysis Configuration
The
DeepcopyDataflowAnalysisclass now accepts adisabled_callsargument, allowing users to specify call name patterns (using wildcards) that should be ignored during analysis. The logic for checking if a call is disabled is encapsulated in the newis_disabled_callmethod, which usesfnmatchfor pattern matching.The
DataOffloadDeepcopyAnalysistransformation class is updated to extract disabled call patterns from the transformation item configuration and pass them to the dataflow analysis. [1] [2]Test Enhancements
A new test fixture,
deepcopy_abort_code, is added to provide source code and setup for testing the disabled call functionality.A new test,
test_offload_deepcopy_analysis_ignores_unresolved_abor1_replacement, is added to verify that calls matching the disabled pattern (e.g.,ABOR1*) are ignored by the analysis, ensuring that replacement error handler calls are not processed.Dependency and Import Updates
fnmatchmodule is imported to support pattern-based matching of call names.RemoveCodeTransformation.Contributor Declaration
By opening this pull request, I affirm the following: