Improve schema viewer#29
Open
garciampred wants to merge 2 commits into
Open
Conversation
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <title>CDM SQL Schema Explorer</title> | ||
| <meta name="theme-color" content="#0b1f33" /> | ||
| <title>Copernicus Climate SQL Schema Explorer</title> |
Collaborator
There was a problem hiding this comment.
Instead of "Copernicus Climate" its is preferable to stick to established naming conventions:
Copernicus Climate Change Service Common Data Model for Observations
Collaborator
There was a problem hiding this comment.
(and I'm not entirely sure we need the word "SQL" in here?)
| <h1>CDM SQL Schema</h1> | ||
| <div class="nav-brand" aria-label="Copernicus Climate and ECMWF branding"> | ||
| <img src="{COPERNICUS_LOGO_PATH}" alt="Copernicus logo" /> | ||
| <h1 class="title">Observations Common Data Model Explorer</h1> |
Collaborator
There was a problem hiding this comment.
Again, "Observations Common Data Model" isn't a bad idea, but it is important to stick to the same naming conventions throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves scripts/generate_schema_html.py to add an introductory paragraph and change styles and logo according to the C3S branding.