feat!: aggregate losses for temporal downscaler#1069
Open
mc4117 wants to merge 105 commits into
Open
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
3 tasks
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
mchantry
changed the title
mchantry
added
ATS Approved
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
for more information, see https://pre-commit.ci
…-core into feat/aggregate_loss
…-core into feat/aggregate_loss
Member
Author
|
I confirm that the old code and the new code are equivalent 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For temporal consistency when using the temporal downscaler, we have been experimenting with using additional loss functions. We have seen large improvements in consistency especially for precipitation and so would strongly recommend using these loss functions when running the temporal downscaler and would like to implement these in anemoi-core. These include:
min across the window
max across the window
mean across the window
diff across the window
What issue or task does this change relate to?
This PR is related to this issue #1059
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--1069.org.readthedocs.build/en/1069/
📚 Documentation preview 📚: https://anemoi-graphs--1069.org.readthedocs.build/en/1069/
📚 Documentation preview 📚: https://anemoi-models--1069.org.readthedocs.build/en/1069/