fix: Changed FFT2D low-pass filter from enabled to disabled by default#1075
Merged
anaprietonem merged 4 commits intoMay 18, 2026
Merged
Conversation
…ansform Signed-off-by: evenmn <evenmn@mn.uio.no>
havardhhaugen
changed the title
Contributor
|
Looks good, I will bring this up at ATS just to flag the change since it gives us significantly better results. |
havardhhaugen
approved these changes
Apr 28, 2026
github-project-automation
Bot
moved this from To be triaged
to For merging
in Anemoi-dev
Contributor
|
@havardhhaugen did you address this at ATS last week? shall we update the label and merge it? |
OpheliaMiralles
approved these changes
May 8, 2026
mchantry
added
ATS Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have observed that the FFT2D low-pass filter implemented in Anemoi for the FFT2D reduces the quality of the generated fields. Disabling the low-pass filter improves the fine-scale structures of the fields, in particular visible for precipitation and wind. The default setting should therefore be running without the filter.
In the future, we can discuss if it's useful to include the filter code at all, but for now, let's keep it.
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.