Skip to content

perf(ekd): Select datetime before cloning fields#505

Draft
gmertes wants to merge 1 commit into
mainfrom
perf/ekd
Draft

perf(ekd): Select datetime before cloning fields#505
gmertes wants to merge 1 commit into
mainfrom
perf/ekd

Conversation

@gmertes
Copy link
Copy Markdown
Member

@gmertes gmertes commented May 21, 2026

Description

A small performance optimisation: when selecting variables in the ekd input, only clone the dates that we need instead of the whole fieldlist.

Impact is minimal in a forecast configuration, where the input fieldlist only contains a few steps.

But for the temporal downscaler, where the input fields can be a large forecast, this avoids unnecessary cloning of the whole fieldlist, resulting in a small speedup.

Also clean up some of the typings, and remove the old FieldArray in favour of the new FieldList and SimpleFieldList (to be further cleaned up in the 1.0 migration, but this is a first pass).

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation Bot moved this to To be triaged in Anemoi-dev May 21, 2026
@gmertes gmertes marked this pull request as draft May 21, 2026 13:46
@gmertes
Copy link
Copy Markdown
Member Author

gmertes commented May 21, 2026

You know the PR is fire when the test segfaults 🔥

@HCookie
Copy link
Copy Markdown
Member

HCookie commented May 29, 2026

Can this be reviewed, it seems the failure is isolated to the cosmo tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: To be triaged

Development

Successfully merging this pull request may close these issues.

2 participants