Fix retain time coordinate#1072
Open
Alfie5640 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated default profiled to enable add_valid_time_coord
When add_valid_time_coord=True, converting GRIB data containing a single valid time could fail during xarray conversion.
The failure occurred because scalar "valid_time" values were incorrectly assigned a coordinate dimension: ValueError: dimensions ('valid_time',) must have the same length as the number of data dimensions, ndim=0
This change updates coordinate dimension inference so scalar coordinate values are represented with no dimensions ( dims=() ), while non-scalar coordinates retain their inferred dimensions
Tests
Added a regression test covering the single valid time case to make sure that
Ran all tests with pytest
Contributor Declaration
By opening this pull request, I affirm the following: