Skip to content

Commit 268faaf

Browse files
committed
Keep node test definitions alive
Retain the Defs object for the fixture lifetime to prevent dangling parent references and segmentation faults during generated-variable lookup. Re ECFLOW-2110
1 parent 2420c7a commit 268faaf

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

libs/pyext/test/py_u_TestNode.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def suite_task():
2121
family = suite.add_family("family")
2222
family.add_repeat(ecf.RepeatDate("REPEAT", 20010101, 20010102, 1))
2323
task = family.add_task("task")
24-
return suite, family, task
24+
return defs, suite, family, task
2525

2626

2727
SUITE_GENERATED_VAR_NAMES = [
@@ -65,7 +65,7 @@ def suite_task():
6565

6666

6767
def test_retrieve_suite_generated_variables_using_variable_list(suite_task):
68-
suite, _, _ = suite_task
68+
_, suite, _, _ = suite_task
6969
vars = ecf.VariableList()
7070
suite.get_generated_variables(vars)
7171
names = {v.name() for v in vars}
@@ -75,7 +75,7 @@ def test_retrieve_suite_generated_variables_using_variable_list(suite_task):
7575

7676

7777
def test_retrieve_suite_generated_variables_using_python_list(suite_task):
78-
suite, _, _ = suite_task
78+
_, suite, _, _ = suite_task
7979
vars = suite.get_generated_variables()
8080
names = {v.name() for v in vars}
8181

@@ -84,7 +84,7 @@ def test_retrieve_suite_generated_variables_using_python_list(suite_task):
8484

8585

8686
def test_retrieve_family_generated_variables_using_variable_list(suite_task):
87-
_, family, _ = suite_task
87+
_, _, family, _ = suite_task
8888
vars = ecf.VariableList()
8989
family.get_generated_variables(vars)
9090
names = {v.name() for v in vars}
@@ -94,7 +94,7 @@ def test_retrieve_family_generated_variables_using_variable_list(suite_task):
9494

9595

9696
def test_retrieve_family_generated_variables_using_python_list(suite_task):
97-
_, family, _ = suite_task
97+
_, _, family, _ = suite_task
9898
vars = family.get_generated_variables()
9999
names = {v.name() for v in vars}
100100

@@ -103,7 +103,7 @@ def test_retrieve_family_generated_variables_using_python_list(suite_task):
103103

104104

105105
def test_retrieve_task_generated_variables_using_variable_list(suite_task):
106-
_, _, task = suite_task
106+
_, _, _, task = suite_task
107107
vars = ecf.VariableList()
108108
task.get_generated_variables(vars)
109109
names = {v.name() for v in vars}
@@ -113,7 +113,7 @@ def test_retrieve_task_generated_variables_using_variable_list(suite_task):
113113

114114

115115
def test_retrieve_task_generated_variables_using_python_list(suite_task):
116-
_, _, task = suite_task
116+
_, _, _, task = suite_task
117117
vars = task.get_generated_variables()
118118
names = {v.name() for v in vars}
119119

0 commit comments

Comments
 (0)