Fix out-of-bounds write in TextPagerEdit#392
Merged
Merged
Conversation
TextEditPrivate::actions was sized with the enumerator value SelectAllAction (i.e. 1) rather than an element count, leaving room for a single QAction while the constructor initialises two. The write to actions[1] hit the adjacent sectionPressed member; being undefined behaviour, at -O0 it merely corrupted that member, while at -O2 GCC 14 used the single-element bound to constrain the loop index and broke the loop exit condition, making ecFlowUI segfault whenever a TextPagerEdit was constructed, as is the case with Panels > Add info panel. Introduce ActionCount and size the array with it, replace the null-sentinel loop with a bounded loop, and tie the shortcut table to ActionType with a static_assert.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #392 +/- ##
========================================
Coverage 52.07% 52.07%
========================================
Files 1247 1247
Lines 101710 101710
Branches 15136 15136
========================================
Hits 52968 52968
Misses 48742 48742 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See commit message(s).
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-392