PLOT: allow and ignore animate arg in plot command outside jupyter env [MPY-317]

Author: iainrussell

metview/bindings.py

@@ -1107,12 +1107,7 @@ def __call__(self, *args, **kwargs):
 # generates a widget allowing the user to select between plot frames
 def plot_to_notebook(*args, **kwargs):  # pragma: no cover
 
-    if not plot.plot_to_jupyter:
-        raise EnvironmentError(
-            "animate() can only be used after calling setoutput('jupyter')"
-        )
-
-    animation_mode = kwargs.get("animate", "auto") # True, False or "auto"
+    animation_mode = kwargs.get("animate", "auto")  # True, False or "auto"
 
     # create all the widgets first so that the 'waiting' label is at the bottom
     image_widget = widgets.Image(
@@ -1202,7 +1197,6 @@ def plot_frame(frame_index):
         im_file.close()
         image_widget.value = imf
 
- 
     # everything is ready now, so plot the first frame, hide the
     # 'waiting' label and reveal the plot and the frame slider
     plot_frame(1)
@@ -1218,6 +1212,7 @@ def setoutput(*args, **kwargs):
     if "jupyter" in args:  # pragma: no cover
         try:
             import IPython
+
             get_ipython = IPython.get_ipython
         except ImportError as imperr:
             print("Could not import IPython module - plotting to Jupyter will not work")
@@ -1237,7 +1232,9 @@ def setoutput(*args, **kwargs):
             global widgets
             widgets = __import__("ipywidgets", globals(), locals())
         except ImportError as imperr:
-            print("Could not import ipywidgets module - plotting to Jupyter will not work")
+            print(
+                "Could not import ipywidgets module - plotting to Jupyter will not work"
+            )
             raise imperr
 
     else:

tests/test_metview.py

@@ -1510,7 +1510,8 @@ def test_plot_2():
         "contour_shade_colour_direction": "clockwise",
     }
     degraded_field = mv.read(data=TEST_FIELDSET, grid=[4, 4])
-    mv.plot(png, degraded_field, mv.mcont(grid_shade))
+    # animate=True just to check that it is allowed and ignored as a param
+    mv.plot(png, degraded_field, mv.mcont(grid_shade), animate=True)
     output_name_from_magics = output_name + ".1.png"
     assert os.path.isfile(output_name_from_magics)
     os.remove(output_name_from_magics)
@@ -1557,12 +1558,6 @@ def test_plot_2_pages():
     os.remove(output_name_from_magics)
 
 
-def test_animate_exception():
-    # this should fail because we are not in a Jupyter environment
-    with pytest.raises(EnvironmentError):
-        mv.plot(animate=True)
-
-
 def test_macro_error():
     with pytest.raises(Exception):
         TEST_FIELDSET[125]