fix(handler): clear hovered state after mouseout. close #1035#1161
Open
jesco-absolut wants to merge 1 commit into
Open
fix(handler): clear hovered state after mouseout. close #1035#1161jesco-absolut wants to merge 1 commit into
jesco-absolut wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1035
Summary
When the pointer leaves the ZRender area from a hovered element,
mouseoutis dispatched but the internal hovered state is not cleared. If the pointer then re-enters from the same position over the same element,mouseoveris skipped becausemousemovestill sees the previous hovered target as current.This patch clears
_hoveredinHandler.mouseoutso re-entering the same element correctly firesmouseoveragain.Root cause
In
src/Handler.ts:mouseoutdispatched the event tothis._hoveredthis._hoveredremained pointing to the old elementmousemove,lastHoveredTargetandhoveredTargetwere the samemouseoverbranch was not enteredChange
this._hoveredto an emptyHoveredResultinHandler.mouseoutTest
Added
test/ut/spec/Handler.test.tscovering:mousemoveinto an element →mouseovermouseoutfrom canvasmousemoveback into the same elementmouseoverfires againValidation
Passed:
Note:
npm run checktypecurrently fails on a pre-existing upstream TypeScript issue insrc/canvas/Painter.ts, unrelated to this change.