fix(export-orders): properly checking last status and prevent integration loop

fixes #121

fixes #124

Author: leomp12

functions/lib/integration/export-order.js

@@ -2,7 +2,7 @@ const errorHandling = require('../store-api/error-handling')
 const Tiny = require('../tiny/constructor')
 const parseOrder = require('./parsers/order-to-tiny/')
 const parseStatus = require('./parsers/order-to-tiny/status')
-const selectTypeUpdate = require('./helpers/select-type-update')
+const getOrderUpdateType = require('./helpers/get-order-update-type')
 const handleJob = require('./handle-job')
 
 module.exports = ({ appSdk, storeId, auth }, tinyToken, queueEntry, appData, canCreateNew) => {
@@ -17,38 +17,16 @@ module.exports = ({ appSdk, storeId, auth }, tinyToken, queueEntry, appData, can
       }
       const tiny = new Tiny(tinyToken)
       console.log(`#${storeId} ${orderId} searching order ${order.number}`)
-      const findLatestUpdate = order => {
-        const fulfillments = order.fulfillments
-        const paymentsHistory = order.payments_history
-        let latestFulfillment, latestPayment
-        if (Array.isArray(fulfillments)) {
-          latestFulfillment = fulfillments.reduce((a, b) => (a.date_time > b.date_time ? a : b))
-        }
-        if (Array.isArray(paymentsHistory)) {
-          latestPayment = paymentsHistory.reduce((a, b) => (a.date_time > b.date_time ? a : b))
-        }
-        if (latestFulfillment && latestPayment) {
-          return latestFulfillment.date_time > latestPayment.date_time ? latestFulfillment : latestPayment
-        } else if (latestFulfillment && !latestPayment) {
-          return latestFulfillment
-        } else if (!latestFulfillment && latestPayment) {
-          return latestPayment
-        }
-      }
-      const latestUpdateStatus = findLatestUpdate(order)
-      if (selectTypeUpdate(latestStatusUpdate) === 'fulfillment') {
-        const checkFulfillmentFromTiny = order => {
-          const fulfillmentStatus = order.fulfillment_status && order.fulfillment_status.current
-          if (fulfillmentStatus && Array.isArray(order.fulfillments)) {
-            return Boolean(order.fulfillments.find(({ status, flags }) => {
-              return status === fulfillmentStatus && flags && flags.includes('from-tiny')
-            }))
+      if (getOrderUpdateType(order) === 'fulfillment') {
+        const fulfillmentStatus = order.fulfillment_status && order.fulfillment_status.current
+        if (fulfillmentStatus && Array.isArray(order.fulfillments)) {
+          const fulfillmentFromTiny = order.fulfillments.find(({ status, flags }) => {
+            return status === fulfillmentStatus && flags && flags.includes('from-tiny')
+          })
+          if (fulfillmentFromTiny) {
+            console.log(`#${storeId} ${orderId} skipped to not send status came by tiny`)
+            return null
           }
-          return false
-        }
-        if (checkFulfillmentFromTiny(order)) {
-          console.log(`#${storeId} ${orderId} skipped to not send status came by tiny`)
-          return null
         }
       }
 

functions/lib/integration/helpers/get-order-update-type.js

@@ -0,0 +1,45 @@
+module.exports = order => {
+  let latestUpdate
+  const fulfillments = order.fulfillments
+  const paymentsHistory = order.payments_history
+  let latestFulfillment, latestPayment
+  if (Array.isArray(fulfillments)) {
+    latestFulfillment = fulfillments.reduce((a, b) => (a.date_time > b.date_time ? a : b))
+  }
+  if (Array.isArray(paymentsHistory)) {
+    latestPayment = paymentsHistory.reduce((a, b) => (a.date_time > b.date_time ? a : b))
+  }
+  if (latestFulfillment && latestPayment) {
+    latestUpdate = latestFulfillment.date_time > latestPayment.date_time
+      ? latestFulfillment : latestPayment
+  } else if (latestFulfillment) {
+    latestUpdate = latestFulfillment
+  } else if (latestPayment) {
+    latestUpdate = latestPayment
+  } else {
+    return null
+  }
+  switch (latestUpdate.status) {
+    case 'pending':
+    case 'under_analysis':
+    case 'unknown':
+    case 'authorized':
+    case 'partially_paid':
+    case 'voided':
+    case 'refunded':
+    case 'in_dispute':
+    case 'unauthorized':
+    case 'paid':
+      return 'financial'
+    case 'in_production':
+    case 'in_separation':
+    case 'invoice_issued':
+    case 'ready_for_shipping':
+    case 'shipped':
+    case 'partially_shipped':
+    case 'delivered':
+    case 'returned':
+      return 'fulfillment'
+  }
+  return null
+}