Skip to content

feat: add community contribution for MCP lab#1356

Open
BiprofessionalPrasad wants to merge 5 commits into
ed-donner:mainfrom
BiprofessionalPrasad:PrasadGaitonde/6MCP_branch
Open

feat: add community contribution for MCP lab#1356
BiprofessionalPrasad wants to merge 5 commits into
ed-donner:mainfrom
BiprofessionalPrasad:PrasadGaitonde/6MCP_branch

Conversation

@BiprofessionalPrasad
Copy link
Copy Markdown
Contributor

Agents course, week 6 , MCP servers final lab day 6.
The goal is to implement a GitHub Agent that follows the modular MCP (Model Context Protocol) architecture established in the current project. This architecture separates
domain-specific logic into standalone MCP servers and uses a client bridge to expose those capabilities to an LLM. The GitHub Agent will allow the LLM to interact with GitHub
repositories, issues, and pull requests while maintaining the same observability and configuration patterns.

@ed-donner
Copy link
Copy Markdown
Owner

Hey - this is great - would you be OK to remove the uv.lock from the PR.. thanks much

@ed-donner
Copy link
Copy Markdown
Owner

Hey,
I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged - please can I ask you to review this:

https://edwarddonner.com/pr

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I very much look forward to merging when this is addressed. Thanks so much
Ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants