feat(select): Hugely simplify HTML select definitions#225
Open
edcarroll wants to merge 5 commits into
Open
Conversation
Value was often unclear
This reverts commit 3730636.
Owner
Author
|
@trevordaniels this is a first attempt at what we discussed in #134. What are your thoughts on this way of doing things? Unfortunately I haven't yet found a way to simplify the options template any further than currently, though I'm still investigating. |
|
I don't know if in this new version it's allowed to search on properties of embedded objects of options, like: labelField = "object.property" (in 0.9.6 is giving an error). |
|
this would be useful - any chance of getting it merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is WIP
This PR is aiming to address #134. It introduces a new way of defining a select, namely:
It is no longer required for you to have to write the
*ngFormanually.However, this doesn't eliminate the ability to specify more complex markup within the select. For example, adding a header to a select is done like so:
The results are rendered at the bottom.
However, if your markup is more complex still, you can manually specify the entry point for the options, like so:
Finally, if you want to manually specify the options, you can still do so by simply putting:
Note that
valuehas been renamed tooption, as this makes it a bit more clear.