feat(message): Add notification functionality#242
Open
edcarroll wants to merge 3 commits into
Open
Conversation
Owner
Author
|
@mcosta74 remade the PR manually so the diff is no longer stupid. |
Contributor
|
What is the status on this? @edcarroll do you need extra hands? |
Owner
Author
|
@harogaston component is fully implemented, just want some feedback on the interface and how it works 😄 Check out the test component which has an active demo |
|
as per gitter
for (1) and (2) I basically think if you could make a notification have the same ui as a message that would be great , as it would handle the colors, icons etc |
|
is it likely that this pr will make it into the main codebase ? Been waiting on it for some time now ;) |
benjaminforras
added a commit
to benjaminforras/ngx-fomantic-ui
that referenced
this pull request
Apr 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is WIP
This PR adds toast style notifications to the message components, as outlined in #103.
Will update this comment with more info when I have more time.