Hebrew localization#250
Open
gotenxds wants to merge 70 commits into
Open
Conversation
This stops it from being erased by Typescript, so when people use it in decorators it still exists. Closes edcarroll#171
Partially addresses edcarroll#165
weekdaysShort for Wednesday was "Mie" should be "Mié"
Thank you to @medfx for the excellent suggestion!
…oll#236) * fix(select): Manually run change detector when option updates Closes edcarroll#213 * style(select): Fixed tslint error
* fix(popup): Fixed conflict with BrowserAnimationsModule Closes edcarroll#204 * style(popup): Fixed tslint error
…dcarroll#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164 * Added comments.
* en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting
…roll#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses edcarroll#165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting
* fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef
* fix: Fixed AOT on SystemJS builder Closes edcarroll#209 * fix: Added custom FocusEvent interface (edcarroll#231) * fix: Added custom FocusEvent interface Closes edcarroll#202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error * chore(popup): Relaxed popper.js dependency (edcarroll#228) Follows up on edcarroll#195 * fix(popup): Fixed delay causing destroyed view errors (edcarroll#233) Closes edcarroll#189 * fix(select): Manually run change detector when option updates (edcarroll#236) * fix(select): Manually run change detector when option updates Closes edcarroll#213 * style(select): Fixed tslint error * fix(select): Selected options now updated when options change (edcarroll#232) * fix(modal): Fixed aggressive autofocus sometimes causing errors (edcarroll#237) * fix(popup): Fixed conflict with BrowserAnimationsModule (edcarroll#234) * fix(popup): Fixed conflict with BrowserAnimationsModule Closes edcarroll#204 * style(popup): Fixed tslint error * feat(popup): Added template context support (edcarroll#238) * fix(popup): Fixed focus events on popup (edcarroll#243) * feat(datepicker) Popup now honors locale and pickerLocaleOverrides (edcarroll#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164 * Added comments. * Time of day values supported in locale definitions (edcarroll#214) * en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting * feat(datepicker) Added initial date support for the datepicker (edcarroll#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses edcarroll#165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting * fix: Various minor bugfixes (edcarroll#245) * fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef * fix: Fixed AOT on SystemJS builder Closes edcarroll#209
Fixes style issue introduced by a long locale formatting string
…-localization # Conflicts: # src/behaviors/localization/locales/he.ts
edcarroll
requested changes
Aug 17, 2017
Owner
edcarroll
left a comment
edcarroll
left a comment
There was a problem hiding this comment.
Thank you for updating this, though couple of things to change
| @@ -1,5 +1,3 @@ | |||
| import { RecursivePartial, ILocaleValues } from "../interfaces/values"; | |||
Owner
There was a problem hiding this comment.
Removing this causes the build error, please put it back
| @@ -1,11 +1,11 @@ | |||
| import { IPartialLocaleValues } from "../interfaces/values"; | |||
| import { ILocaleValues } from "../interfaces/values"; | |||
Owner
There was a problem hiding this comment.
Please leave this as IPartialLocaleValues so the build doesn't break if we add more values.
| */ | ||
|
|
||
| const he:IPartialLocaleValues = { | ||
| const he:ILocaleValues = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested here #223