Skip to content

feat(select): Added ability to clear select#412

Open
avaneev95 wants to merge 2 commits into
edcarroll:masterfrom
avaneev95:feat(select)/clearable
Open

feat(select): Added ability to clear select#412
avaneev95 wants to merge 2 commits into
edcarroll:masterfrom
avaneev95:feat(select)/clearable

Conversation

@avaneev95
Copy link
Copy Markdown
Contributor

@avaneev95 avaneev95 commented Sep 2, 2018

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • linted, built and tested the changes locally.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

This PR adds a isClearable property to the SuiSelect to allow the ability to deselect an option.
It can be useful if you are using a select as a filter and want the ability to reset it.

Here the example:
clearable-select

@marcbernal
Copy link
Copy Markdown

Hi, do you have any estimation on when will this PR be merged ?

<sui-select class="selection"
[(ngModel)]="selectedOption"
[options]="filters"
[isClearable]="true"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this fix in old version ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants