tweaks to Actual365NoLeap transition

Author: eddelbuettel

man/BondUtilities.Rd

@@ -44,6 +44,18 @@ matchParams(params)
 }
 \details{
   The QuantLib documentation should be consulted for details.
+
+  Note that \code{Actual365NoLeap} is soft deprecated as of QuantLib 1.11 and hard deprecated as of
+  QuantLib 1.16. For users on QuantLib 1.16 or later, use of the RQuantLib daycounter enum with a
+  value of severn will result in \code{Actual365Fixed(Actual365Fixed::NoLeap)} which is functionally
+  equivalent to \code{Actual365NoLeap}. Previously RQuantLib allowed users to retain
+  \code{Actual365NoLeap} via defining \code{RQUANTLIB_USE_ACTUAL365NOLEAP}, but this is no longer
+  required.
+
+  Also note that \code{ActualActual} without explicit convention specification is hard deprecated
+  as of QuantLib 1.23. This is only soft-deprecated in RQuantLib by explicitly passing in the same
+  default convention. Previously RQuantLib allowed users to define
+  \code{RQUANTLIB_USE_ACTUALACTUAL}, but this is no longer required.
 }
 \references{\url{https://www.quantlib.org/} for details on \code{QuantLib}.}
 \author{Khanh Nguyen \email{knguyen@cs.umb.edu} for the \R interface;

src/utils.cpp

@@ -378,7 +378,7 @@ QuantLib::DayCounter getDayCounter(const double n){
     else if (n==6)
         return QuantLib::Thirty360(QuantLib::Thirty360::BondBasis);  // reasonable default for back compatibility
     else if (n==7)
-#if QL_HEX_VERSION >= 0x011600f0
+#if QL_HEX_VERSION >= 0x011600f0 && !defined(RQUANTLIB_USE_ACTUAL365NOLEAP)
         return QuantLib::Actual365Fixed(QuantLib::Actual365Fixed::NoLeap);
 #else
         return QuantLib::Actual365NoLeap();