Skip to content

Commit 0d40192

Browse files
committed
ci: pre-commit branding BMPs, remove broken ImageMagick CI steps
Chocolatey ImageMagick on Windows runners lacks PNG codec delegates, causing prepare-branding.ps1 to fail with: magick.exe: no decode delegate for this image format Fix: generate header.bmp (150x57) and welcome.bmp (164x314) on macOS using Homebrew ImageMagick from img/linux-collection.png, commit them to the repo, and remove the Install ImageMagick and Generate installer branding assets CI steps entirely. BMPs will be regenerated locally when the source image changes.
1 parent f6f0a6f commit 0d40192

4 files changed

Lines changed: 2 additions & 9 deletions

File tree

.github/workflows/build-windows-installer.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,6 @@ jobs:
5555
shell: pwsh
5656
run: choco install nsis --no-progress -y
5757

58-
- name: Install ImageMagick
59-
shell: pwsh
60-
run: choco install imagemagick --no-progress -y
61-
62-
- name: Generate installer branding assets
63-
shell: pwsh
64-
run: windows-installer/prepare-branding.ps1
65-
6658
- name: Build NSIS installer
6759
shell: pwsh
6860
run: |

windows-installer/.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
staging/
22
output/
3-
branding/
3+
# Only ignore generated sub-folder; header.bmp / welcome.bmp are pre-built and committed.
4+
branding/generated/
25.2 KB
Binary file not shown.
151 KB
Binary file not shown.

0 commit comments

Comments
 (0)