Skip to content

Commit cbb7380

Browse files
committed
treewide: bump supported vCPU count to kernel maximum of 220
1 parent fa2497e commit cbb7380

5 files changed

Lines changed: 7 additions & 6 deletions

File tree

cli/verifier/cpu_count_valid.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
// CPUCountValid verifies that all workloads have a valid vCPU count.
1616
type CPUCountValid struct{}
1717

18-
// Verify checks that pods do not require more than the currently supported 8 vCPUs.
18+
// Verify checks that pods do not require more than the currently supported 220 vCPUs.
1919
func (v *CPUCountValid) Verify(toVerify any) error {
2020
var findings error
2121

@@ -25,9 +25,9 @@ func (v *CPUCountValid) Verify(toVerify any) error {
2525
}
2626

2727
cpuCount := kuberesource.GetPodCPUCount(spec)
28-
if cpuCount < 1 || cpuCount > 8 {
28+
if cpuCount < 1 || cpuCount > 220 {
2929
// TODO(charludo): find way to add pod name to error message
30-
findings = errors.Join(findings, fmt.Errorf("pod failed verification: currently only 0-7 additional vCPUs are supported (1-8 vCPUs in total), but %d were requested", cpuCount))
30+
findings = errors.Join(findings, fmt.Errorf("pod failed verification: currently only 1-220 vCPUs are supported, but %d were requested", cpuCount))
3131
}
3232

3333
return spec

cli/verifier/cpu_count_valid_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ spec:
6262
- name: app
6363
resources:
6464
limits:
65-
cpu: "8" # invalid because of always-added CPU
65+
cpu: "220" # invalid because of always-added CPU
6666
`
6767

6868
func TestCPUCountValid(t *testing.T) {

docs/docs/architecture/components/manifest.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ It covers the guest firmware, the initrd and kernel as well as the kernel comman
132132
The kernel command line contains the dm-verity hash of the root filesystem, which contains all Contrast components that run inside the guest.
133133

134134
It's the (launch) `MEASUREMENT` from the SNP `ATTESTATION_REPORT`, according to Table 23 in the [SEV ABI Spec].
135+
Contrast is able to extrapolate from this single-vCPU measurement to those for up to 220 vCPUs.
135136

136137
### `ReferenceValues.snp.*.MinimumTCB` {#snp-minimum-tcb}
137138

docs/docs/howto/workload-deployment/deployment-file-preparation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ Altogether, setting the limit to 10x the compressed image size should be suffici
196196
:::warning
197197

198198
Each Contrast pod requires one CPU by default.
199-
Containers may request additional CPUs, up to a total of 8 CPUs per pod.
199+
Containers may request additional CPUs, up to a total of 220 CPUs per pod.
200200
Please note that fractional CPU requests are always rounded up to the nearest whole number, meaning a Pod with one container requesting 0.2 CPUs will require 2 CPUs in total.
201201

202202
:::

tools/vale/styles/config/vocabularies/edgeless/accept.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ URIs?
187187
userland
188188
UUID
189189
validators?
190-
vCPU
190+
vCPUs?
191191
vendored
192192
virsh
193193
virtualized

0 commit comments

Comments
 (0)