kata.runtime-rs: init#1909
Open
katexochen wants to merge 14 commits intomainfrom
Open
Conversation
katexochen
force-pushed
the
p/runtime-rs
branch
from
6976756 to
b3b8041
Compare
katexochen
force-pushed
the
p/runtime-rs
branch
4 times, most recently
from
642e71f to
6a88531
Compare
burgerdev
reviewed
Apr 1, 2026
katexochen
force-pushed
the
p/runtime-rs
branch
4 times, most recently
from
af8d8b8 to
d8a36d5
Compare
burgerdev
force-pushed
the
p/runtime-rs
branch
3 times, most recently
from
a11fb04 to
f85e5d1
Compare
charludo
reviewed
May 5, 2026
toml parsing in runtime-go and node-installer is case-insensitive, but the crate used in runtime-rs is case sensitive and expects lower-case keys.
runtime-rs uses vastly different kernel parameters, so we can't just reuse the ones from runtime-go. To make matters worse, the user-provided parameters are not appended, but show up somewhere in the middle. This commit changes the `runtime(-rs).cmdline` to expose two functions, prefix and suffix. They take a boolean `debug` argument, matching the debug settings for the runtime. Since we don't support debug for runtime-rs, the argument is not yet used there. I also changed from a string to a list of words, to make joining the empty suffix easier.
burgerdev
approved these changes
May 6, 2026
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
I did some very minor changes in @katexochen's commits which are not worthy of re-review by a second team member.
Member
|
Current status: working on SNP, not working on TDX due to RTMR mismatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.