treewide: decouple vCPU count from number of SNP ReferenceValues in manifest#2301
Closed
charludo wants to merge 5 commits into
Closed
treewide: decouple vCPU count from number of SNP ReferenceValues in manifest#2301charludo wants to merge 5 commits into
ReferenceValues in manifest#2301charludo wants to merge 5 commits into
Conversation
ReferenceValues in manifestReferenceValues in manifest
|
thomasten
reviewed
Apr 10, 2026
4dee224 to
34ff6f9
Compare
34ff6f9 to
7a33a15
Compare
This was referenced Apr 10, 2026
Collaborator
Author
|
Closed in favor of #2344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrustedMeasurementsSince version
1.19.0, Contrast supports multi-CPU pods. As part of that change, manifests significantly increased in size, since an additionalReferenceValuesblock was included for each possible vCPU count.With this PR, this is again reduced to a single
ReferenceValuesblock, just as pre-1.19.0. At the same time, theTrustedMeasurementfield has been converted toTrustedMeasurements(plural), mapping each supported vCPU count to the appropriate launch measurement.A manifest previously containing
needs to be changed to follow the new format shown below:
Only the measurements for the actually required vCPU counts need to be included.
contrast generateautomatically filters for these required counts when generating the manifest.Additionally, the maximum amount of supported vCPUs has been bumped from 8 to 220.
Please see the documentation for further details.
Backward- and forward-compatibility
For compatibility of older CLI versions with the new manifest layout, the old
TrustedMeasurementfield will, for the time being, still be populated with the measurement corresponding to the number of vCPUs the Coordinator is assigned. This allows older CLI versions toverifynewer Contrast deployments.Conversely, manifests generated with an older versions of the CLI will still be accepted by newer versions of the CLI, which fall back to the old
TrustedMeasurementfield if the newTrustedMeasurementsare not present.The
TrustedMeasurementfield will be deprecated at an as of yet undetermined point in time. Please ensure your Contrast version stays up to date.