cli: extrapolate vCPU launch measurements from single-cpu value#2344
Merged
Conversation
|
charludo
force-pushed
the
ch/embedded-measurements-with-gotool
branch
from
390e2fe to
5944551
Compare
Do the documentation changes need to be backported?Changes to
|
charludo
added
feature
Collaborator
Author
burgerdev
reviewed
May 6, 2026
| // In unit tests the embedded ap-eip.hex is a placeholder, so we skip | ||
| // using the value. This means we fall back to assuming the launch digest to be exact. | ||
| if apEIP, err := parsedAPEIP(); err != nil { | ||
| log.Warn("AP EIP not available; falling back to pre-computed launch digests", "err", err) |
Member
There was a problem hiding this comment.
What kind of situation may lead to this?
Collaborator
Author
There was a problem hiding this comment.
The AP EID not being available, you mean? As the comment says, unit tests (or more precisely, unit tests ran with go test), since the ap-eid.hex file gets populated only during nix build. Pretty sure we have/had exceptions like this for the embedded reference values as well, since they have the same issue.
charludo
force-pushed
the
ch/embedded-measurements-with-gotool
branch
from
5944551 to
cdefe6c
Compare
Collaborator
Author
charludo
force-pushed
the
ch/embedded-measurements-with-gotool
branch
from
cdefe6c to
481a419
Compare
charludo
force-pushed
the
ch/embedded-measurements-with-gotool
branch
from
481a419 to
e043d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.