fix(chat): follow URLs on RET even when wrapped in emphasis

A bare URL wrapped in markdown emphasis like **https://...** is
fontified with a list face (markdown-plain-url-face plus the bold
face), so the eq check in eca-chat--key-pressed-return missed it and
RET did nothing. thing-at-point also pulls in the trailing ** since
asterisks are valid URL chars.

Detect link/url faces via membership (works for a symbol or a list)
and strip surrounding * _ ~ ` markers before browse-url. Proper
[text](url) links still go through markdown-follow-thing-at-point.

Author: ericdallo

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Add `eca-chat-delete` command to delete the active chat from the server without prompting. Works from any buffer in the project (acts on the session's last visited chat), switches the chat window to another chat first when one exists, and is bound to `C-c C-S-k` plus a `Delete` entry in the transient menu.
+- Bugfix: pressing `RET` on a URL in the chat now opens it even when the URL is wrapped in markdown emphasis like `**https://...**` or `_https://..._`. The face at point is a list in that case, so the old `eq` check missed it; the trailing `**`/`_` markers are also stripped so the right URL opens. Proper `[text](url)` links still go through `markdown-follow-thing-at-point`.
 - Bugfix: switching chat tabs via `tab-line-switch-to-next-tab`/`tab-line-switch-to-prev-tab` or clicking a tab now switches the chat in place instead of opening it in a new window.
 - Bugfix: trigger `@`/`#` chat completion even when a char like `(` immediately precedes it.
 - Bugfix: don't crash with `(wrong-type-argument stringp nil)` when `chat/askQuestion` sends options as plain strings or option objects without a `:label`. Options are normalized via `eca-chat--normalize-question-option` (string or plist) and the label always falls back to a non-nil string.

eca-chat.el

@@ -1578,6 +1578,27 @@ Does not send directly — `eca-chat--send-queued-prompt' handles sending."
    ((bound-and-true-p completion-in-region-mode)
     (completion-at-point))))
 
+(defun eca-chat--face-at-point-member-p (faces)
+  "Return non-nil when the `face' text property at point includes any of FACES.
+The `face' property may be a single symbol or a list of faces: a bare
+URL wrapped in emphasis such as **https://...** carries both
+`markdown-plain-url-face' and `markdown-bold-face', so a plain `eq'
+against a single symbol would miss it."
+  (let ((prop (get-text-property (point) 'face)))
+    (seq-some (lambda (f) (memq f faces))
+              (if (listp prop) prop (list prop)))))
+
+(defun eca-chat--follow-link-at-point ()
+  "Open the markdown link or URL at point in the chat buffer.
+Handles inline [text](url) links as well as bare URLs, including bare
+URLs wrapped in markdown emphasis like **https://...** or _https://..._
+where `thing-at-point' would otherwise capture the trailing markup
+characters as part of the URL."
+  (if (eca-chat--face-at-point-member-p '(markdown-plain-url-face))
+      (when-let* ((url (thing-at-point 'url t)))
+        (browse-url (string-trim url "[*_~`]+" "[*_~`]+")))
+    (markdown-follow-thing-at-point nil)))
+
 (defun eca-chat--key-pressed-return ()
   "Send the current prompt to eca process if in prompt."
   (interactive)
@@ -1600,12 +1621,13 @@ Does not send directly — `eca-chat--send-queued-prompt' handles sending."
        (let ((ov (eca-chat--expandable-content-at-point)))
          (eca-chat--expandable-content-toggle (overlay-get ov 'eca-chat--expandable-content-id))))
 
-      ;; follow markdown link [text](url)
-      ((let ((face (get-text-property (point) 'face)))
-         (or (eq face 'markdown-link-face)
-             (eq face 'markdown-url-face)
-             (eq face 'markdown-plain-url-face)))
-       (markdown-follow-thing-at-point nil))
+      ;; follow markdown link [text](url) or a bare URL, even when the URL
+      ;; is wrapped in emphasis like **https://...** (face is then a list,
+      ;; so check membership instead of `eq' against a single symbol).
+      ((eca-chat--face-at-point-member-p '(markdown-link-face
+                                           markdown-url-face
+                                           markdown-plain-url-face))
+       (eca-chat--follow-link-at-point))
 
       ;; pending question + freeform allowed — answer with prompt text
       ((and eca-chat--pending-question

test/eca-chat-test.el

@@ -30,6 +30,19 @@ Returns the buffer.  Caller must kill it."
     (buffer-substring-no-properties
      (eca-chat--prompt-field-start-point) (point-max))))
 
+(defun eca-chat-test--call-on (text marker fn)
+  "Fontify TEXT in a gfm buffer, move point onto MARKER, then call FN.
+TEXT is inserted on the third line (after a heading) so markdown
+does not treat the first line as metadata.  Returns FN's value."
+  (with-temp-buffer
+    (insert "# Title\n\n" text)
+    (delay-mode-hooks (gfm-mode))
+    (font-lock-ensure)
+    (goto-char (point-min))
+    (search-forward marker)
+    (goto-char (match-beginning 0))
+    (funcall fn)))
+
 ;; ---------------------------------------------------------------------------
 ;; Tests
 ;; ---------------------------------------------------------------------------
@@ -273,4 +286,80 @@ Returns the buffer.  Caller must kill it."
       (expect (stringp (car res)) :to-be-truthy)
       (expect (cdr res) :to-equal "no label"))))
 
+(describe "eca-chat--face-at-point-member-p"
+  ;; A bare URL wrapped in emphasis (**url**, _url_) gets a list-valued
+  ;; `face' property, so detection must not rely on `eq' to a symbol.
+  (it "matches when the face is a single symbol"
+    (with-temp-buffer
+      (insert (propertize "x" 'face 'markdown-plain-url-face))
+      (goto-char (point-min))
+      (expect (eca-chat--face-at-point-member-p '(markdown-plain-url-face))
+              :to-be-truthy)))
+
+  (it "matches when the face is a list (emphasized URL)"
+    (with-temp-buffer
+      (insert (propertize "x" 'face '(markdown-plain-url-face markdown-bold-face)))
+      (goto-char (point-min))
+      (expect (eca-chat--face-at-point-member-p '(markdown-plain-url-face))
+              :to-be-truthy)))
+
+  (it "returns nil when no listed face is present"
+    (with-temp-buffer
+      (insert (propertize "x" 'face 'font-lock-comment-face))
+      (goto-char (point-min))
+      (expect (eca-chat--face-at-point-member-p '(markdown-plain-url-face))
+              :to-be nil)))
+
+  (it "returns nil when there is no face at point"
+    (with-temp-buffer
+      (insert "x")
+      (goto-char (point-min))
+      (expect (eca-chat--face-at-point-member-p '(markdown-plain-url-face))
+              :to-be nil))))
+
+(describe "eca-chat--follow-link-at-point"
+
+  (it "opens a bare URL"
+    (eca-chat-test--call-on
+     "see https://github.com/nubank/nucli/pull/10063 here" "github.com"
+     (lambda ()
+       (spy-on 'browse-url)
+       (spy-on 'markdown-follow-thing-at-point)
+       (eca-chat--follow-link-at-point)
+       (expect 'browse-url :to-have-been-called-with
+               "https://github.com/nubank/nucli/pull/10063")
+       (expect 'markdown-follow-thing-at-point :not :to-have-been-called))))
+
+  (it "opens a bold URL without the trailing ** markers"
+    ;; Regression: **https://...** fontifies the URL with a list face and
+    ;; `thing-at-point' captures the trailing "**"; both used to break RET.
+    (eca-chat-test--call-on
+     "see **https://github.com/nubank/nucli/pull/10063** here" "github.com"
+     (lambda ()
+       (spy-on 'browse-url)
+       (spy-on 'markdown-follow-thing-at-point)
+       (eca-chat--follow-link-at-point)
+       (expect 'browse-url :to-have-been-called-with
+               "https://github.com/nubank/nucli/pull/10063")
+       (expect 'markdown-follow-thing-at-point :not :to-have-been-called))))
+
+  (it "opens an italic URL without the trailing _ marker"
+    (eca-chat-test--call-on
+     "see _https://github.com/nubank/nucli/pull/10063_ here" "github.com"
+     (lambda ()
+       (spy-on 'browse-url)
+       (eca-chat--follow-link-at-point)
+       (expect 'browse-url :to-have-been-called-with
+               "https://github.com/nubank/nucli/pull/10063"))))
+
+  (it "defers a proper [text](url) link to markdown-follow-thing-at-point"
+    (eca-chat-test--call-on
+     "see [PR](https://github.com/nubank/nucli/pull/10063) here" "github.com"
+     (lambda ()
+       (spy-on 'browse-url)
+       (spy-on 'markdown-follow-thing-at-point)
+       (eca-chat--follow-link-at-point)
+       (expect 'markdown-follow-thing-at-point :to-have-been-called)
+       (expect 'browse-url :not :to-have-been-called)))))
+
 ;;; eca-chat-test.el ends here