Chat buffer does not use read-only and intangible text properties

[nehrbash]

I just wanted to bring attention that Emacs has text properties to guard non-editable regions with the read-only text property. I would guess it would be desirable if most of the chat buffer would be guarded by read only. It seems like this was at one point attempted? Saw this commented out ;; (setq-local buffer-read-only loading) and there are several references to inhibit-read-only t so it looks mostly set up. I think when implemented you should be able to remove all these advice-add calls.

    ;; TODO is there a better way to do that?
    (advice-add 'delete-char :around #'eca-chat--key-pressed-deletion)
    (advice-add 'backward-kill-word :around #'eca-chat--key-pressed-deletion)
    (when (featurep 'evil)
      (advice-add 'evil-delete-backward-word :around #'eca-chat--key-pressed-deletion)
      (advice-add 'evil-delete-back-to-indentation :around #'eca-chat--key-pressed-deletion)
      (advice-add 'evil-delete-whole-line :around #'eca-chat--key-pressed-deletion)
      (advice-add 'evil-delete-char :around #'eca-chat--key-pressed-deletion)
      (advice-add 'evil-delete :around #'eca-chat--key-pressed-deletion)
      (advice-add 'evil-delete-backward-char :around #'eca-chat--key-pressed-deletion))

Similarly, the cursor-intangible text property (or cursor-intangible-mode) would stop point from landing inside purely decorative spans. I am mainly thinking about the area around the prompt prefix. after scrolling past the page break the cursor could jump right to the prompt area.

[ericdallo]

Oh I didn't know about that text property, thank you!
Yeah, I believe if that works we can improve a lot the code.

Similarly, the cursor-intangible text property (or cursor-intangible-mode) would stop point from landing inside purely decorative spans. I am mainly thinking about the area around the prompt prefix. after scrolling past the page break the cursor could jump right to the prompt area.

Interesting too! but what part exactly because the > is already a line-prefix, so user can't go there or remove it

[ericdallo]

I gave it a quick try, but it seems it's not that easy, will leave to try again later

[snoopier]

Push

I also noticed that it's possible to paste code before ">" and after streaming server response. Also before "Stop"
And that stuff Never go away. No show killer but maybe the approach above Sounds nice

BR Dennis
Love eca change my life :-)

[ericdallo]

Yeah I need to try again with more time because although could sound easy, this breaks a lot of stuff in eca emacs