perf(chat): cache context bar rendering#262
Open
itkonen wants to merge 1 commit into
Open
Conversation
Avoid rebuilding the context usage mode-line bar on every mode-line evaluation during assistant streaming. The cache key tracks the actual rendering inputs so usage updates and graphical fallback color changes still invalidate naturally. Add focused streaming benchmarks to compare default, no-context, and no-mode-line rendering paths. 🤖 Generated with [ECA](https://eca.dev) (openai/gpt-5.5 - high) Co-Authored-By: eca-agent <git@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the CPU load increased after the introduction of the context bar - enough to make it the bottleneck on older computers - so I did some benchmarking and found the problem. I'm not quite sure if this fix is ideal, but at least it brought down the CPU load.
AI Summary
Verification
emacs -Q --batch -L . ... --batch -f batch-byte-compile eca-chat.el benchmarks/eca-chat-bench.elemacs -Q --batch -L . -L test ... -l buttercup -l test/eca-chat-test.el -f buttercup-runemacs -Q --batch -L . ... -l benchmarks/eca-chat-bench.el -f eca-chat-bench-run-streaminggit diff --check🤖 Generated with ECA (openai/gpt-5.5 - high)