Set defaults, fix tests

Author: tomgeorge

lua/eca/config.lua

@@ -11,9 +11,20 @@ M._defaults = {
   ---@type string
   usage_string_format = "{messageCost} / {sessionCost}",
   log = {
-    level = "info", -- Log level as string: "trace", "debug", "info", "warn", "error"
-    notify = true, -- Enable vim.notify logging
-    file = false, -- false = no file logging, true = default XDG path, string = custom path
+    ---@type "info"|"warn"|"error"|"debug"|"trace|off"
+    --- Log level as string.
+    --- Default: "info".
+    --- See vim.log.levels for a list of log levels
+    level = "info",
+    ---@type boolean
+    ---Use vim.notify for log messages
+    ---Default: false
+    notify = false,
+    ---@type boolean|string
+    --- If true, logs to $XDG_STATE_DIR/nvim/eca.log (see vim.fn.stdpath)
+    --- If a string, log to that file path
+    --- Default: true
+    file = true,
   },
   behaviour = {
     auto_set_keymaps = true,

lua/eca/logger.lua

@@ -3,7 +3,7 @@ local uv = vim.uv or vim.loop
 ---@class eca.Logger
 local M = {}
 
-local config = nil
+M.config = nil
 
 local LEVEL_NAMES = {
   [vim.log.levels.TRACE] = "TRACE",
@@ -77,7 +77,14 @@ end
 --- Initialize logger with configuration
 ---@param user_config table
 function M.setup(user_config)
-  config = user_config
+  -- Extract log config and set defaults
+  local log_config = user_config and user_config.log or {}
+
+  M.config = {
+    level = log_config.level or "info",
+    notify = log_config.notify ~= nil and log_config.notify or false,
+    file = log_config.file ~= nil and log_config.file or true,
+  }
 
   -- Check log file size on startup and notify if too large
   if M.is_file_logging_enabled() then
@@ -91,22 +98,28 @@ end
 --- Check if file logging is enabled
 ---@return boolean
 function M.is_file_logging_enabled()
-  return config and config.log and config.log.file and resolve_log_path(config.log.file) ~= nil
+  if not M.config then
+    return false
+  end
+
+  -- If file is true, we use default path, if it's a string, we use custom path
+  -- If file is false, file logging is disabled
+  return M.config.file == true or type(M.config.file) == "string"
 end
 
 --- Check if notifications are enabled
 ---@return boolean
 function M.is_notify_enabled()
-  return config and config.log and config.log.notify or false
+  return M.config and M.config.notify or false
 end
 
 --- Get current log file path
 ---@return string|nil
 function M.get_log_path()
-  if not config or not config.log then
+  if not M.config then
     return nil
   end
-  return resolve_log_path(config.log.file)
+  return resolve_log_path(M.config.file)
 end
 
 --- Main logging function
@@ -116,25 +129,29 @@ end
 function M.log(message, level, opts)
   opts = opts or {}
 
-  -- Early return if no config or logging disabled
-  if not config or not config.log then
+  -- Early return if no config
+  if not M.config then
     return
   end
 
-  local min_level = get_log_level(config.log.level)
+  local min_level = get_log_level(M.config.level)
   if level < min_level then
     return
   end
 
-  if opts.notify then
+  -- Determine if we should notify
+  local should_notify = opts.notify == true or (opts.notify == nil and opts.file == nil and M.config.notify)
+  if should_notify then
     vim.notify(message, level, {
       title = opts.title or "ECA",
       once = opts.once,
     })
   end
 
-  if opts.file then
-    local log_path = resolve_log_path(config.log.file)
+  -- Determine if we should log to file
+  local should_log_to_file = opts.file == true or (opts.file == nil and opts.notify == nil and M.config.file)
+  if should_log_to_file then
+    local log_path = resolve_log_path(M.config.file)
     if log_path then
       -- Ensure parent directory exists
       vim.fn.mkdir(vim.fn.fnamemodify(log_path, ":h"), "p")