Removing unnecessary notifications#19
Merged
Merged
Conversation
W3ND31
requested review from
Copilot and
tomgeorge
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary notifications that were displayed to users without debug mode enabled, reducing notification noise. The changes focus on converting informational logging to debug-level logging and commenting out status bar notifications.
- Downgraded server startup messages from
infotodebuglevel - Commented out status bar notification that showed status text to users
- Removed entire NUI sidebar implementation file
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lua/eca/status_bar.lua | Commented out vim.notify call to prevent status notifications from appearing |
| lua/eca/server.lua | Changed server startup success message from info to debug level |
| lua/eca/nui_sidebar.lua | Completely removed NUI sidebar implementation (1346 lines deleted) |
| lua/eca/init.lua | Changed server startup and status messages from info to debug level |
| lua/eca/commands.lua | Added empty lines (no functional changes) |
Comments suppressed due to low confidence (1)
ericdallo
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're discussing on #15, we have some notifications that the user doesn't need to see if they aren't with debug enabled. So, this PR fix this behaviour