Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the async server download functionality, simplifying the server startup process and removing related selection commands. The changes restore synchronous server path resolution and remove model/behavior selection features that were previously added.
Key changes:
- Reverted server path finding to synchronous operation without async download
- Removed model and behavior selection commands and associated test files
- Updated configuration property from "behavior" to "behaviour" for consistency
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_state.lua | Updated usage limit property and removed model/behavior update tests |
| tests/test_server_path.lua | Completely removed server path testing functionality |
| tests/test_server_integration.lua | Simplified server tests, removed path validation tests |
| tests/test_select_commands.lua | Removed all model/behavior selection command tests |
| scripts/server_path.lua | Removed server path resolution script |
| plugin-spec.lua | Changed "behavior" to "behaviour" in configuration |
| lua/eca/utils.lua | Removed lua_quote utility function |
| lua/eca/state.lua | Updated usage tracking and removed model/behavior update methods |
| lua/eca/sidebar.lua | Updated welcome message and removed model/behavior from chat requests |
| lua/eca/server.lua | Reverted to synchronous server startup with simplified path finding |
| lua/eca/path_finder.lua | Simplified path finding logic and improved error handling |
| lua/eca/mediator.lua | Removed model/behavior selection helper methods |
| lua/eca/init.lua | Updated configuration references and auto-start behavior |
| lua/eca/config.lua | Changed "behavior" to "behaviour" and updated defaults |
| lua/eca/commands.lua | Removed model and behavior selection commands |
| lua/eca/api.lua | Removed server running check before opening chat |
| docs/ | Updated documentation to use "behaviour" spelling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| -- Make executable (if not Windows) | ||
| if not uv.os_uname().sysname:lower():match("windows") then | ||
| if not vim.loop.os_uname().sysname:lower():match("windows") then |
There was a problem hiding this comment.
Using deprecated vim.loop instead of vim.uv. Should use vim.uv.os_uname() for consistency with the import at the top of the file.
| if not vim.loop.os_uname().sysname:lower():match("windows") then | |
| if not uv.os_uname().sysname:lower():match("windows") then |
| Logger.error("ECA server is not running") | ||
| if callback then | ||
| callback("Server not running", nil) | ||
| end |
There was a problem hiding this comment.
Missing return statement after the error handling. The function continues to execute and attempt to send the request even when the server is not running.
| end | |
| end | |
| return |
…-server-download Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…
No description provided.