Skip to content

Revert async server download#49

Merged
ericdallo merged 2 commits intomainfrom
revert-async-server-download
Oct 9, 2025
Merged

Revert async server download#49
ericdallo merged 2 commits intomainfrom
revert-async-server-download

Conversation

@joaopluigi
Copy link
Copy Markdown
Contributor

No description provided.

…l-and-behavior"

This reverts commit 9c90bad, reversing
changes made to 8ae1e0a.
…r-download"

This reverts commit 8ae1e0a, reversing
changes made to 6161194.
Copilot AI review requested due to automatic review settings October 9, 2025 19:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the async server download functionality, simplifying the server startup process and removing related selection commands. The changes restore synchronous server path resolution and remove model/behavior selection features that were previously added.

Key changes:

  • Reverted server path finding to synchronous operation without async download
  • Removed model and behavior selection commands and associated test files
  • Updated configuration property from "behavior" to "behaviour" for consistency

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_state.lua Updated usage limit property and removed model/behavior update tests
tests/test_server_path.lua Completely removed server path testing functionality
tests/test_server_integration.lua Simplified server tests, removed path validation tests
tests/test_select_commands.lua Removed all model/behavior selection command tests
scripts/server_path.lua Removed server path resolution script
plugin-spec.lua Changed "behavior" to "behaviour" in configuration
lua/eca/utils.lua Removed lua_quote utility function
lua/eca/state.lua Updated usage tracking and removed model/behavior update methods
lua/eca/sidebar.lua Updated welcome message and removed model/behavior from chat requests
lua/eca/server.lua Reverted to synchronous server startup with simplified path finding
lua/eca/path_finder.lua Simplified path finding logic and improved error handling
lua/eca/mediator.lua Removed model/behavior selection helper methods
lua/eca/init.lua Updated configuration references and auto-start behavior
lua/eca/config.lua Changed "behavior" to "behaviour" and updated defaults
lua/eca/commands.lua Removed model and behavior selection commands
lua/eca/api.lua Removed server running check before opening chat
docs/ Updated documentation to use "behaviour" spelling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread lua/eca/path_finder.lua

-- Make executable (if not Windows)
if not uv.os_uname().sysname:lower():match("windows") then
if not vim.loop.os_uname().sysname:lower():match("windows") then
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using deprecated vim.loop instead of vim.uv. Should use vim.uv.os_uname() for consistency with the import at the top of the file.

Suggested change
if not vim.loop.os_uname().sysname:lower():match("windows") then
if not uv.os_uname().sysname:lower():match("windows") then

Copilot uses AI. Check for mistakes.
Comment thread lua/eca/server.lua
Logger.error("ECA server is not running")
if callback then
callback("Server not running", nil)
end
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return statement after the error handling. The function continues to execute and attempt to send the request even when the server is not running.

Suggested change
end
end
return

Copilot uses AI. Check for mistakes.
@ericdallo ericdallo merged commit ad26f36 into main Oct 9, 2025
3 checks passed
joaopluigi added a commit that referenced this pull request Oct 10, 2025
…c-server-download"

This reverts commit ad26f36, reversing
changes made to 9c90bad.
joaopluigi added a commit that referenced this pull request Oct 10, 2025
…-server-download

Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants