Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…#50
Merged
joaopluigi merged 4 commits intomainfrom Oct 10, 2025
Merged
Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…#50joaopluigi merged 4 commits intomainfrom
joaopluigi merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous commit that had introduced changes related to async server download functionality. The revert restores the previous behavior for server initialization and path handling.
Key changes include:
- Reverts server startup to use synchronous path resolution instead of async download
- Restores config key from
behaviourtobehavior(American spelling) - Adds new chat selection commands for models and behaviors
- Updates server integration and path finding functionality
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_state.lua | Adds tests for model/behavior selection and updates usage limit field |
| tests/test_server_path.lua | New test file for server path resolution functionality |
| tests/test_server_integration.lua | Updates server integration tests with new startup behavior |
| tests/test_select_commands.lua | New test file for chat selection commands |
| scripts/server_path.lua | New script for server path resolution |
| plugin-spec.lua | Corrects spelling from behaviour to behavior |
| lua/eca/utils.lua | Adds lua_quote utility function |
| lua/eca/state.lua | Updates usage field and adds model/behavior selection methods |
| lua/eca/sidebar.lua | Updates welcome message and adds model/behavior params to chat requests |
| lua/eca/server.lua | Major refactor of server startup logic to use sync path resolution |
| lua/eca/path_finder.lua | Updates error handling and removes custom path logic |
| lua/eca/mediator.lua | Adds methods for model/behavior management |
| lua/eca/init.lua | Updates config key spelling and conditional server startup |
| lua/eca/config.lua | Corrects spelling and changes default auto_start_server to false |
| lua/eca/commands.lua | Adds new commands for selecting models and behaviors |
| lua/eca/api.lua | Adds automatic server startup when opening chat |
| docs/*.md | Updates documentation to use correct behavior spelling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…c-server-download"
This reverts commit ad26f36, reversing changes made to 9c90bad.