Skip to content

Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…#50

Merged
joaopluigi merged 4 commits intomainfrom
revert-revert-async-server-download
Oct 10, 2025
Merged

Revert "Merge pull request #49 from editor-code-assistant/revert-asyn…#50
joaopluigi merged 4 commits intomainfrom
revert-revert-async-server-download

Conversation

@joaopluigi
Copy link
Copy Markdown
Contributor

…c-server-download"

This reverts commit ad26f36, reversing changes made to 9c90bad.

@joaopluigi joaopluigi marked this pull request as ready for review October 10, 2025 18:53
Copilot AI review requested due to automatic review settings October 10, 2025 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous commit that had introduced changes related to async server download functionality. The revert restores the previous behavior for server initialization and path handling.

Key changes include:

  • Reverts server startup to use synchronous path resolution instead of async download
  • Restores config key from behaviour to behavior (American spelling)
  • Adds new chat selection commands for models and behaviors
  • Updates server integration and path finding functionality

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_state.lua Adds tests for model/behavior selection and updates usage limit field
tests/test_server_path.lua New test file for server path resolution functionality
tests/test_server_integration.lua Updates server integration tests with new startup behavior
tests/test_select_commands.lua New test file for chat selection commands
scripts/server_path.lua New script for server path resolution
plugin-spec.lua Corrects spelling from behaviour to behavior
lua/eca/utils.lua Adds lua_quote utility function
lua/eca/state.lua Updates usage field and adds model/behavior selection methods
lua/eca/sidebar.lua Updates welcome message and adds model/behavior params to chat requests
lua/eca/server.lua Major refactor of server startup logic to use sync path resolution
lua/eca/path_finder.lua Updates error handling and removes custom path logic
lua/eca/mediator.lua Adds methods for model/behavior management
lua/eca/init.lua Updates config key spelling and conditional server startup
lua/eca/config.lua Corrects spelling and changes default auto_start_server to false
lua/eca/commands.lua Adds new commands for selecting models and behaviors
lua/eca/api.lua Adds automatic server startup when opening chat
docs/*.md Updates documentation to use correct behavior spelling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread lua/eca/path_finder.lua
Comment thread lua/eca/server.lua Outdated
Copy link
Copy Markdown
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@joaopluigi joaopluigi merged commit 80e3be4 into main Oct 10, 2025
3 checks passed
@joaopluigi joaopluigi deleted the revert-revert-async-server-download branch October 10, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants