Auto-approve eca__read_file for tool call output cache files (~/.cache/eca/toolCallOutputs).

Author: ericdallo

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fix MCP server initialization crash (`String cannot be cast to IPersistentCollection`) when OAuth metadata endpoint returns a non-JSON or error response.
+- Auto-approve `eca__read_file` for tool call output cache files (`~/.cache/eca/toolCallOutputs`).
 
 ## 0.110.3
 

src/eca/features/tools/util.clj

@@ -69,11 +69,14 @@
 
 (defn path-outside-workspace?
   "Returns true if `path` is outside any workspace root in `db`.
+   Paths inside the ECA tool-call-outputs cache dir are always considered 'inside'.
    Works for existing or non-existing paths by absolutizing."
   [db path]
   (let [p (when path (str (fs/absolutize path)))
         roots (workspace-root-paths db)]
-    (and p (not-any? #(fs/starts-with? p %) roots))))
+    (and p
+         (not (fs/starts-with? p (str (cache/tool-call-outputs-dir))))
+         (not-any? #(fs/starts-with? p %) roots))))
 
 (defn require-approval-when-outside-workspace
   "Returns a function suitable for tool `:require-approval-fn` that triggers

test/eca/features/tools/util_test.clj

@@ -6,6 +6,7 @@
    [clojure.test :refer [deftest is testing use-fixtures]]
    [eca.cache :as cache]
    [eca.features.tools.util :as tools.util]
+   [eca.test-helper :as h]
    [matcher-combinators.test :refer [match?]]))
 
 (def ^:private test-tool-call-id "test-truncation-call-1")
@@ -146,3 +147,12 @@
     (let [result (make-result "")
           config (config-with-truncation 5 10)]
       (is (= result (tools.util/maybe-truncate-output result config "call-empty"))))))
+
+(deftest path-outside-workspace-allows-tool-call-outputs-dir-test
+  (testing "path inside tool-call-outputs cache dir is not considered outside workspace"
+    (let [db {:workspace-folders [{:uri (h/file-uri "file:///home/user/project") :name "project"}]}
+          cache-path (str (cache/tool-call-outputs-dir) "/some-call-id.txt")]
+      (is (false? (tools.util/path-outside-workspace? db cache-path)))))
+  (testing "path outside workspace and not in cache dir is still outside"
+    (let [db {:workspace-folders [{:uri (h/file-uri "file:///home/user/project") :name "project"}]}]
+      (is (true? (tools.util/path-outside-workspace? db (h/file-path "/tmp/random/file.txt")))))))