Fix remote.enabled in project-local .eca/config.json being ignored when a global config also exists.

Author: ericdallo

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Fix auto-continue clobbering new prompt status and losing the stop button.
 - Add configurable shell for `shell_command` tool via `toolCall.shellCommand.path` and `toolCall.shellCommand.args`. #370
 - Fix providers disappearing from `/login` after saving an API key. eca-emacs#196
+- Fix `remote.enabled` in project-local `.eca/config.json` being ignored when a global config also exists.
 
 ## 0.116.5
 

src/eca/handlers.clj

@@ -62,7 +62,7 @@
 
       {:chat-welcome-message (welcome-message config)})))
 
-(defn initialized [{:keys [db* messenger config metrics]}]
+(defn initialized [{:keys [db* messenger config metrics start-remote-server!] :as components}]
   (metrics/task metrics :eca/initialized
     (let [sync-models-and-notify!
           (fn [config]
@@ -98,6 +98,8 @@
                                                      db*)))))))]
       (swap! db* assoc-in [:config-updated-fns :sync-models] #(sync-models-and-notify! %))
       (shared/future* config (sync-models-and-notify! config))))
+  (when (get-in config [:remote :enabled])
+    (start-remote-server! components))
   (future
     (Thread/sleep 1000) ;; wait chat window is open in some editors.
     (when-let [error (config/validation-error)]

src/eca/server.clj

@@ -177,28 +177,27 @@
   (let [db* (atom (assoc db/initial-db :started-at (System/currentTimeMillis)))
         metrics (->Metrics db*)
         stdio-messenger (->ServerMessenger server db*)
-        ;; Read remote config from file-based sources (global/env/custom).
-        ;; Workspace-level config is not available yet (initialize hasn't been called).
-        remote-config (:remote (config/read-file-configs))
-        sse-connections* (when (:enabled remote-config)
-                           (atom #{}))
-        messenger (if sse-connections*
-                    (remote.messenger/->BroadcastMessenger stdio-messenger sse-connections*)
-                    stdio-messenger)
+        ;; Always create SSE connections and BroadcastMessenger so the remote
+        ;; HTTP server can be started later (e.g. when local project config
+        ;; enables it after initialize). Broadcasting to an empty set is a no-op.
+        sse-connections* (atom #{})
+        messenger (remote.messenger/->BroadcastMessenger stdio-messenger sse-connections*)
+        start-remote-server!
+        (fn [components]
+          (when-let [rs (remote.server/start! components sse-connections*)]
+            (reset! remote-server* rs)
+            (swap! db* assoc
+                   :remote-connect-url (:connect-url rs)
+                   :remote-host (:host rs)
+                   :remote-token (:token rs)
+                   :remote-private-host? (:private-host? rs))))
         components {:db* db*
                     :messenger messenger
                     :metrics metrics
-                    :server server}]
+                    :server server
+                    :start-remote-server! start-remote-server!}]
     (logger/info "[server]" "Starting server...")
     (metrics/start! metrics)
-    (when sse-connections*
-      (when-let [rs (remote.server/start! components sse-connections*)]
-        (reset! remote-server* rs)
-        (swap! db* assoc
-               :remote-connect-url (:connect-url rs)
-               :remote-host (:host rs)
-               :remote-token (:token rs)
-               :remote-private-host? (:private-host? rs))))
     (monitor-server-logs (:log-ch server))
     (setup-dev-environment db* components)
     (jsonrpc.server/start server components)))