Add move_file native tool

Author: ericdallo

README.md

@@ -27,7 +27,7 @@ A Free and OpenSource editor-agnostic tool that aims to easily link LLMs <-> Edi
 - **Editor-agnostic** protocol for any editor to integrate.
 - **Single configuration**: Configure eca making it work the same in any editor.
 - **Chat** interface: ask questions, review diffs, work together with an agent in your codebase.
-- **Agentic** let LLM work as an agent with its built-in tools and MCPs you can configure.
+- **Agentic** let LLM work as an agent with its native tools and MCPs you can configure.
 - **Context** support: giving more details about your code to the LLM.
 - **Multi models**: Ollama local models, OpenAI, Anthropic, more on the way.
 

docs/capabilities.md

@@ -15,6 +15,7 @@ Provides access to filesystem under workspace root, listing and reading files an
 - `search_files`: search in a path for files matching a pattern.
 - `grep`: ripgrep/grep for paths with specified content.
 - `replace_in_file`: replace a text with another one in file.
+- `move_file`: move/rename a file.
 
 ### TODO - Shell
 

src/eca/features/tools/filesystem.clj

@@ -130,7 +130,7 @@
 
 (defn ^:private grep
   "Searches for files containing patterns using regular expressions.
-   
+
    This function provides a fast content search across files using three different
    backends depending on what's available:
    1. ripgrep (rg) - fastest, preferred when available
@@ -182,6 +182,17 @@
              (format "Successfully replaced content in %s." path))
            (format "Original content not found in %s" path))))))
 
+(defn ^:private move-file [arguments db]
+  (let [workspace-dirs (tools.util/workspace-roots-strs db)]
+    (or (invalid-arguments arguments [["source" fs/exists? "$source is not a valid path"]
+                                      ["source" (partial allowed-path? db) (str "Access denied - path $source outside allowed directories: " workspace-dirs)]
+                                      ["destination" (partial allowed-path? db) (str "Access denied - path $destination outside allowed directories: " workspace-dirs)]
+                                      ["destination" (complement fs/exists?) "Path $destination already exists"]])
+        (let [source (get arguments "source")
+              destination (get arguments "destination")]
+          (fs/move source destination {:replace-existing false})
+          (single-text-content (format "Successfully moved %s to %s" source destination))))))
+
 (def definitions
   {"list_directory"
    {:description (str "Get a detailed listing of all files and directories in a specified path. "
@@ -260,7 +271,19 @@
                                                   :description "Whether to replace all occurences of the file or just the first one (default)"}}
                   :required ["path" "original_content" "new_content"]}
     :handler #'replace-in-file}
-   ;; TODO move-file
+   "move_file"
+   {:description (str "Move or rename files and directories. Can move files between directories "
+                      "and rename them in a single operation. If the destination exists, the "
+                      "operation will fail. Works across different directories and can be used "
+                      "for simple renaming within the same directory. "
+                      "Both source and destination must be within the directories: $workspaceRoots.")
+    :parameters  {:type "object"
+                  :properties {"source" {:type "string"
+                                         :description "The absolute origin file path to move."}
+                               "destination" {:type "string"
+                                              :description "The new absolute file path to move to."}}
+                  :required ["source" "destination"]}
+    :handler #'move-file}
    ;; TODO write-file
    ;; TODO delete-files
    })

test/eca/features/tools/filesystem_test.clj

@@ -303,3 +303,40 @@
       (is (match?
            {(h/file-path "/project/foo/my-file.txt") "Hey, here is another-boring-text in this file! here as well: another-boring-text"}
            @file-content*)))))
+
+(deftest move-file-test
+  (testing "Not readable source path"
+    (is (match?
+         {:contents [{:type :text
+                      :error true
+                      :content (format "%s is not a valid path" (h/file-path "/foo/qux"))}]}
+         (with-redefs [fs/exists? (constantly false)
+                       f.tools.filesystem/allowed-path? (constantly true)]
+           ((get-in f.tools.filesystem/definitions ["move_file" :handler])
+            {"source" (h/file-path "/foo/qux")}
+            {:workspace-folders [{:uri (h/file-uri "file:///foo/bar/baz") :name "foo"}]})))))
+  (testing "Destination already exists"
+    (is (match?
+         {:contents [{:type :text
+                      :error true
+                      :content (format "Path %s already exists" (h/file-path "/foo/bar/other_file.clj"))}]}
+         (with-redefs [fs/exists? (constantly true)
+                       f.tools.filesystem/allowed-path? (constantly true)]
+           ((get-in f.tools.filesystem/definitions ["move_file" :handler])
+            {"source" (h/file-path "/foo/bar/some_file.clj")
+             "destination" (h/file-path "/foo/bar/other_file.clj")}
+            {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]})))))
+  (testing "Move successfully"
+    (is (match?
+         {:contents [{:type :text
+                      :error false
+                      :content (format "Successfully moved %s to %s"
+                                       (h/file-path "/foo/bar/some_file.clj")
+                                       (h/file-path "/foo/bar/other_file.clj"))}]}
+         (with-redefs [fs/exists? (fn [path] (not (string/includes? path "other_file.clj")))
+                       f.tools.filesystem/allowed-path? (constantly true)
+                       fs/move (constantly true)]
+           ((get-in f.tools.filesystem/definitions ["move_file" :handler])
+            {"source" (h/file-path "/foo/bar/some_file.clj")
+             "destination" (h/file-path "/foo/bar/other_file.clj")}
+            {:workspace-folders [{:uri (h/file-uri "file:///foo/bar") :name "foo"}]}))))))