Improve stop prompt reliability and fix multiple race conditions

- Fix duplicate "Prompt stopped" message when stopping with a running
  subagent by adding silent mode to prompt-stop
- Fix delayed newline after stop by suppressing belated statusChanged
  notification from the finally block via prompt-finished? flag
- Make finish-chat-prompt! idempotent — hooks and progress fire exactly
  once per prompt regardless of how many callers invoke it
- Add prompt-finished? to cancelled? callback and assert-chat-not-stopped!
  to block LLM retries and bail out stream callbacks after finish
- Fix stop during auto-compacting leaving the flag stuck forever by
  clearing compacting flags in prompt-stop
- Suppress error message text sent to client when stopping (cosmetic)
- Reduce stream watchdog poll interval from 2000ms to 500ms for faster
  stop responsiveness

🤖 Generated with [eca](https://eca.dev)

Co-Authored-By: eca <git@eca.dev>

Author: ericdallo

src/eca/features/chat.clj

@@ -525,6 +525,7 @@
                 :cancelled? (fn []
                               (let [chat (get-in @db* [:chats chat-id])]
                                 (or (identical? :stopping (:status chat))
+                                    (:prompt-finished? chat)
                                     (not= prompt-id (:prompt-id chat)))))
                 :on-retry (fn [{:keys [attempt max-retries delay-ms classified]}]
                             (let [{error-type :error/type error-label :error/label} classified
@@ -759,7 +760,8 @@
                                               :auto-continue
                                               (assoc chat-ctx :auto-continued? true))))))
                                     (do
-                                      (lifecycle/send-content! chat-ctx :system {:type :text :text (str "\n\n" (or message (str "Error: " (or (ex-message exception) (.getName (class exception))))))})
+                                      (when-not stopping?
+                                        (lifecycle/send-content! chat-ctx :system {:type :text :text (str "\n\n" (or message (str "Error: " (or (ex-message exception) (.getName (class exception))))))}))
                                       (lifecycle/finish-chat-prompt! :idle (dissoc chat-ctx :on-finished-side-effect))))))))})
               (catch Exception e
                 (when-not (:silent? (ex-data e))
@@ -1046,6 +1048,8 @@
          (tc/transition-tool-call! db* chat-ctx tool-call-id :stop-requested
                                    {:reason {:code :user-prompt-stop
                                              :text "Tool call rejected because of user prompt stop"}}))
+       ;; Clear compacting flags so finish-chat-prompt! isn't blocked
+       (swap! db* update-in [:chats chat-id] dissoc :auto-compacting? :compacting?)
        (lifecycle/finish-chat-prompt! :stopping (dissoc chat-ctx :on-finished-side-effect))))))
 
 (defn delete-chat

src/eca/features/chat/lifecycle.clj

@@ -68,32 +68,33 @@
           content))
 
 (defn finish-chat-prompt! [status {:keys [message chat-id db* messenger metrics config on-finished-side-effect prompt-id] :as chat-ctx}]
-  (when-not (and prompt-id (not= prompt-id (get-in @db* [:chats chat-id :prompt-id])))
-    (when-not (get-in @db* [:chats chat-id :auto-compacting?])
-      (swap! db* assoc-in [:chats chat-id :status] status)
-      (messenger/chat-status-changed messenger {:chat-id chat-id :status status})
-      (let [db @db*
-            subagent? (some? (get-in db [:chats chat-id :subagent]))
-            hook-type (if subagent? :subagentPostRequest :postRequest)
-            hook-data (cond-> (merge (f.hooks/chat-hook-data db chat-id (:agent chat-ctx))
-                                     {:prompt message})
-                        subagent? (assoc :parent-chat-id (get-in db [:chats chat-id :parent-chat-id])))]
-        (f.hooks/trigger-if-matches! hook-type
-                                     hook-data
-                                     {:on-before-action (partial notify-before-hook-action! chat-ctx)
-                                      :on-after-action (partial notify-after-hook-action! chat-ctx)}
-                                     db
-                                     config))
-      (send-content! chat-ctx :system
-                     {:type :progress
-                      :state :finished})
-      (when-not (get-in @db* [:chats chat-id :created-at])
-        (swap! db* assoc-in [:chats chat-id :created-at] (System/currentTimeMillis)))
-      (swap! db* assoc-in [:chats chat-id :prompt-finished?] true))
-    (when (and on-finished-side-effect
-               (not (identical? :stopping (get-in @db* [:chats chat-id :status]))))
-      (on-finished-side-effect))
-    (db/update-workspaces-cache! @db* metrics)))
+  (when-not (get-in @db* [:chats chat-id :prompt-finished?])
+    (when-not (and prompt-id (not= prompt-id (get-in @db* [:chats chat-id :prompt-id])))
+      (when-not (get-in @db* [:chats chat-id :auto-compacting?])
+        (swap! db* assoc-in [:chats chat-id :prompt-finished?] true)
+        (swap! db* assoc-in [:chats chat-id :status] status)
+        (messenger/chat-status-changed messenger {:chat-id chat-id :status status})
+        (let [db @db*
+              subagent? (some? (get-in db [:chats chat-id :subagent]))
+              hook-type (if subagent? :subagentPostRequest :postRequest)
+              hook-data (cond-> (merge (f.hooks/chat-hook-data db chat-id (:agent chat-ctx))
+                                       {:prompt message})
+                          subagent? (assoc :parent-chat-id (get-in db [:chats chat-id :parent-chat-id])))]
+          (f.hooks/trigger-if-matches! hook-type
+                                       hook-data
+                                       {:on-before-action (partial notify-before-hook-action! chat-ctx)
+                                        :on-after-action (partial notify-after-hook-action! chat-ctx)}
+                                       db
+                                       config))
+        (send-content! chat-ctx :system
+                       {:type :progress
+                        :state :finished})
+        (when-not (get-in @db* [:chats chat-id :created-at])
+          (swap! db* assoc-in [:chats chat-id :created-at] (System/currentTimeMillis))))
+      (when (and on-finished-side-effect
+                 (not (identical? :stopping (get-in @db* [:chats chat-id :status]))))
+        (on-finished-side-effect))
+      (db/update-workspaces-cache! @db* metrics))))
 
 (defn maybe-renew-auth-token [chat-ctx]
   (f.login/maybe-renew-auth-token!
@@ -111,7 +112,9 @@
 (defn assert-chat-not-stopped! [{:keys [chat-id db* prompt-id] :as chat-ctx}]
   (let [chat (get-in @db* [:chats chat-id])
         superseded? (and prompt-id (not= prompt-id (:prompt-id chat)))
-        stopped? (or (identical? :stopping (:status chat)) superseded?)]
+        stopped? (or (identical? :stopping (:status chat))
+                     (:prompt-finished? chat)
+                     superseded?)]
     (when stopped?
       (finish-chat-prompt! :idle (dissoc chat-ctx :on-finished-side-effect))
       (logger/info logger-tag "Chat prompt stopped:" chat-id (when superseded? "(superseded)"))