Merge branch 'master' of github.com:editor-code-assistant/eca

# Conflicts:
#	CHANGELOG.md

Author: ericdallo

CHANGELOG.md

@@ -5,6 +5,8 @@
 - Add `providers/list`, `providers/login`, `providers/loginInput`, `providers/logout` requests and `providers/updated` notification for settings-based provider/model management.
 - Add LiteLLM, LM Studio, Mistral, and Moonshot as built-in providers with login support.
 - Fix Z-AI provider config using wrong API type and URL.
+- Improve explorer subagent prompt, remove role based approach.
+- Remove model/variant list from spawn_agent tool description so it doesn't use models when it is not asked to. #369
 
 ## 0.120.1
 

resources/prompts/explorer_agent.md

@@ -1,8 +1,19 @@
-You are a file search specialist. Your role is to locate and retrieve data from the codebase.
+Handle file and codebase search tasks.
 
-Core Constraints:
-- No Writing: Do not create or modify files.
-- Navigation: Use grep for patterns or content search, use read for file inspection if needed.
-- Communication: Be concise. Provide absolute file paths, concrete evidence, and brief findings. No emojis.
+Locate relevant files, symbols, references, and logic paths in the codebase using the provided tools.
 
-Goal: Map the requested logic/files as efficiently as possible and report your findings in a clear way.
+Constraints:
+- Do not create or modify files.
+- Use grep for pattern or content search.
+- Use read only when inspection is necessary.
+- Prefer direct, minimal search steps.
+- Avoid unnecessary exploration.
+- Be concise.
+- Return absolute file paths, concrete evidence, and brief findings.
+- Do not use emojis.
+- Do not speculate when evidence is missing.
+
+Output expectations:
+- Identify the most relevant files or code paths.
+- Show the evidence supporting each finding.
+- Summarize the result clearly and briefly.

resources/prompts/tools/spawn_agent.md

@@ -8,6 +8,4 @@ Agent Limits: Sub-agents cannot spawn other agents (no nesting) and have access
 Strict rules for arguments:
 - 'task': Provide a highly detailed prompt. Explicitly state whether it should write/edit code or just research, how to verify its work, and exactly what specific information it must return to you.
 - 'activity': Must be a concise 3-4 word label for the UI (e.g., "exploring codebase", "refactoring module").
-- 'model' & 'variant': - Only include these keys if the user explicitly requests a specific model or variant. Otherwise, the agent defaults to its default configuration.
-  - If the user did not ask for a model, OMIT the `model` key entirely. Never send an empty string.
-  - If the user did not ask for a variant, OMIT the `variant` key entirely. Never send an empty string.
+- 'model' & 'variant': - NEVER include these arguments if the user hasn't explicitly requested a specific model or variant.

src/eca/features/tools/agent.clj

@@ -5,8 +5,7 @@
    [eca.config :as config]
    [eca.features.tools.util :as tools.util]
    [eca.logger :as logger]
-   [eca.messenger :as messenger]
-   [eca.shared :refer [multi-str]]))
+   [eca.messenger :as messenger]))
 
 (set! *warn-on-reflection* true)
 
@@ -273,32 +272,26 @@
 
 (defn definitions
   [config db]
-  (let [model-names (available-model-names db)
-        variant-names (available-variant-names config db)]
-    {"spawn_agent"
-     {:description (build-description config)
-      :parameters {:type "object"
-                   :properties {"agent" {:type "string"
-                                         :description "Name of the agent to spawn"}
-                                "task" {:type "string"
-                                        :description "The detailed instructions for the agent"}
-                                "activity" {:type "string"
-                                            :description "Concise label (max 3-4 words) shown in the UI while the agent runs, e.g. \"exploring codebase\", \"reviewing changes\", \"analyzing tests\"."}
-                                "model" {:type "string"
-                                         :description (cond-> "Optional model override. Include this key ONLY when the user explicitly asked for a specific model. Otherwise omit the key entirely; never send an empty string."
-                                                        (and (seq model-names) (> (count model-names) 1))
-                                                        (multi-str "One of these models can be used if the user explicitely requests it: " model-names))}
-                                "variant" {:type        "string"
-                                           :description (cond-> "Optional variant override. Include this key ONLY when the user explicitly asked for a specific variant."
-                                                          (seq variant-names) (multi-str "One of these variants can be used if the user requests it: "
-                                                                                         variant-names))}}
-                   :required ["agent" "task" "activity"]}
-      :handler #'spawn-agent
-      :summary-fn (fn [{:keys [args]}]
-                    (if-let [agent-name (get args "agent")]
-                      (let [activity (get args "activity" "working")]
-                        (format "%s: %s" agent-name activity))
-                      "Spawning agent"))}}))
+  {"spawn_agent"
+   {:description (build-description config)
+    :parameters  {:type       "object"
+                  :properties {"agent"    {:type        "string"
+                                           :description "Name of the agent to spawn"}
+                               "task"     {:type        "string"
+                                           :description "The detailed instructions for the agent"}
+                               "activity" {:type        "string"
+                                           :description "Concise label (max 3-4 words) shown in the UI while the agent runs, e.g. \"exploring codebase\", \"reviewing changes\", \"analyzing tests\"."}
+                               "model"    {:type        "string"
+                                           :description "Optional sub-agent model override. Reserved for explicit user override only. Omit unless the user explicitly named a model."}
+                               "variant"  {:type        "string"
+                                           :description "Optional sub-agent model variant override. Reserved for explicit user override only. Omit unless the user explicitly named a variant."}}
+                  :required   ["agent" "task" "activity"]}
+    :handler     #'spawn-agent
+    :summary-fn  (fn [{:keys [args]}]
+                   (if-let [agent-name (get args "agent")]
+                     (let [activity (get args "activity" "working")]
+                       (format "%s: %s" agent-name activity))
+                     "Spawning agent"))}})
 
 (defmethod tools.util/tool-call-details-before-invocation :spawn_agent
   [_name arguments _server {:keys [db config chat-id tool-call-id]}]