Add chat/update notification for renaming chats#404
Merged
Conversation
Persist chat titles to database and broadcast to all connected clients. Previously, renaming was client-local only (lost on restart).
State-modifying operations that persist to DB should use request
semantics so the client gets acknowledgment. This aligns chat/update
with chat/clear, chat/delete, chat/fork, etc.
- Use receive-request + eventually instead of receive-notification
- Return {} from update-chat (consistent with other chat operations)
- Update protocol docs to reflect request semantics
🤖 Generated with [eca](https://eca.dev)
Co-Authored-By: eca <git@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist chat titles to database and broadcast to all connected clients. Previously, renaming was client-local only (lost on restart).