data.url cache bug changes the value internally on 3rd save() call triggered with editor.js.save()#30
Open
sosie-js wants to merge 1 commit intoeditor-js:masterfrom
Conversation
//image.src is not reliable, this was tracked using the editorjs-undo plugin in bigBrother mode
If you add before the return line this code
```js
var strWindowFeatures = "location=no,height=570,width=800,scrollbars=yes,status=yes";
var childWindow= window.open('', "_blank", strWindowFeatures);
childWindow.document.write("<pre>"+JSON.stringify(this.data, null, 4 ) +"</pre>");
childWindow.focus();
```
You will see that starting the 3rd click on editor.js.save() button from editor.js/src/editor.js/example/example-dev.html
that the relative image path 'assets/codex2x.png' is being converted to http url such as http://localhost/editor.js/src/editor.js/example/assets/codex2x.png",
this will be taken as a change and polluate the undo plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//image.src is not reliable, this was tracked using the editorjs-undo plugin in bigBrother mode
If you add before the return line this code
You will see that starting the 3rd click on editor.js.save() button from editor.js/src/editor.js/example/example-dev.html
that the relative image path 'assets/codex2x.png' is being converted to http url such as http://localhost/editor.js/src/editor.js/example/assets/codex2x.png",
this will be taken as a change and polluate the undo plugin