Merge pull request #34 from editor-js/fix/search-query

gohabereg · web-flow · commit 28cbf5fde4a0 · 2026-04-16T20:34:09.000+01:00
Fix search showing nothing when query is an empty string
diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/packages/ui-kit/package.json b/packages/ui-kit/package.json
@@ -2,7 +2,7 @@
   "name": "@editorjs/ui-kit",
   "description": "UI Components for Editor.js",
   "packageManager": "yarn@4.4.0",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/src/index.d.ts",
diff --git a/packages/ui-kit/src/popover/components/search-input/search-input.ts b/packages/ui-kit/src/popover/components/search-input/search-input.ts
@@ -131,6 +131,6 @@ export class SearchInput extends EventsDispatcher<SearchInputEventMap> {
     const text = item.title === undefined ? '' : item.title.toLowerCase();
     const query = this.searchQuery?.toLowerCase();
 
-    return query !== undefined ? text.includes(query) : false;
+    return query !== undefined && query !== '' ? text.includes(query) : false;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,6 @@ export class SearchInput extends EventsDispatcher<SearchInputEventMap> {`
`131`	`131`	`const text = item.title === undefined ? '' : item.title.toLowerCase();`
`132`	`132`	`const query = this.searchQuery?.toLowerCase();`
`133`	`133`
`134`		`- return query !== undefined ? text.includes(query) : false;`
	`134`	`+ return query !== undefined && query !== '' ? text.includes(query) : false;`
`135`	`135`	`}`
`136`	`136`	`}`