Fixing the missing devices when discovering for the first time. Fixes #151#157
Open
ncdm-stldr wants to merge 1 commit into
Open
Fixing the missing devices when discovering for the first time. Fixes #151#157ncdm-stldr wants to merge 1 commit into
ncdm-stldr wants to merge 1 commit into
Conversation
Author
|
Note that to reproduce the issue, one can simply run the example application of the plugin, then explore the scanned devices: the first time we click on the button, we do not see all the devices. We can however see some devices in the logs which are not displayed because startDiscovery doesn't return them. |
DanielLimaFN
approved these changes
Sep 21, 2022
Author
|
@DanielLimaFN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time one call
startDiscovery(), some results are lost and not sent through the stream returned bystartDiscovery.After investigation, it appeared to me this happens because the plugin calls
_methodChannel.invokeMethod('startDiscovery');before listening to the EventChannel_discoveryChannel.Therefore I switched the two code blocks. I also added something to prevent the following situation:
_discoveryChannelEventChannel.