Skip to content

Commit 0dd3f1b

Browse files
eduralphclaude
andcommitted
CI: make unit-test-linux and unit-test-windows blocking — backlog cleared
Drops continue-on-error: true (and the TODO comments) from both unit-test jobs. They were guarding against "currently-broken addon unit modules (import failures, stale API usage)" that have since been fixed by the merged plugin-registration / dep-declaration round (gramps-project#875 WordleGramplet, gramps-project#876 SourceReferences, gramps-project#878 EditExifMetadata, gramps-project#879 MongoDB, gramps-project#880 PhotoTaggingGramplet, gramps-project#869 SurnameMappingGramplet, gramps#2299 ClipboardGramplet) plus the lint backlog (gramps-project#843, gramps-project#847-gramps-project#869). Verified by the most recent fork CI run on eduralph/addons-source:maintenance/gramps60 (sha 8aabdd4, 2026-05-18): both Unit Tests (Linux) and Unit Tests (Windows) reported success. Also clears two stale comments that referenced the removed flag: - unit-test-linux's "Run per-addon unit tests" step: drop the trailing "Falls silently under continue-on-error." sentence. - integration's requires_mod-validate step: collapse the now-moot "this is the blocking copy" rationale to a plain pointer at unit-test-linux. The lone remaining continue-on-error is on addon-structure (line 70), gated by the po/template.pot backlog. PRs gramps-project#838-gramps-project#841 were closed without merge; per Eduard's call the po/template.pot check stays non-blocking for now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d265612 commit 0dd3f1b

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,6 @@ jobs:
150150
unit-test-linux:
151151
name: Unit Tests (Linux)
152152
runs-on: ubuntu-latest
153-
# Non-blocking until the currently-broken addon unit modules (import
154-
# failures, stale API usage) are sorted out in follow-up PRs.
155-
continue-on-error: true
156153
container:
157154
image: ghcr.io/${{ github.repository }}/gramps-ci:gramps60
158155
steps:
@@ -260,7 +257,7 @@ jobs:
260257
# shell: bash — the container's default shell is /bin/sh
261258
# (dash on python:3.12-slim), which does not support the
262259
# ${var//pattern/repl} and ${var%.py} parameter expansions
263-
# used below. Falls silently under continue-on-error.
260+
# used below.
264261
shell: bash
265262
env:
266263
PYTHONPATH: .
@@ -303,8 +300,6 @@ jobs:
303300
unit-test-windows:
304301
name: Unit Tests (Windows)
305302
runs-on: windows-latest
306-
# Non-blocking for the same reason as unit-test-linux.
307-
continue-on-error: true
308303
defaults:
309304
run:
310305
shell: bash -el {0}
@@ -484,9 +479,7 @@ jobs:
484479
fi
485480
486481
- name: Validate requires_mod names against Gramps' dep gate
487-
# See unit-test-linux for rationale. This is the blocking copy:
488-
# integration-test does not set continue-on-error, so a wrong
489-
# requires_mod name surfaces as a CI failure here.
482+
# See unit-test-linux for rationale.
490483
shell: bash
491484
run: |
492485
python3 - <<'PY'

0 commit comments

Comments
 (0)