Commit 7941194
Fix CI failures: lint, compile, addon structure, Windows install
Resolves all failing CI jobs in one pass so the pipeline can go green.
CI config:
- Compile Check: add `shell: bash` (default `sh -e` can't parse the
bash process substitution)
- Windows: switch to conda environment-file so mamba actually installs
Gramps + deps into `addons-ci` (the previous `mamba install` step
silently no-op'd). Adds a Verify step that prints `mamba list` and
imports the deps to fail fast if they aren't there.
Addon structure:
- Create po/template.pot stubs for AnniversariesGramplet, ArchiveAssist,
GrampsChat, GrampyScript — they had no po/ dir at all.
Lint (79 → 0 ruff errors across 29 files):
- Missing imports: WindowActiveError, ErrorDialog, DbTxn, EditDate,
ReportError, EventType, Surname, Any, display_help, reduce, time,
sys, Errors
- 3× `os.name is 'nt'` → `== 'nt'`; tuple-in-if bug in LifeLineChartView
- Removed dead code after `return` in AttachSourceTool; broken stub
line in SourceIndex/index.py
- Python 2 leftovers: `except E(msg)` → `except E as msg`,
`unicode()` → `str()`, removed `basestring`/`reload` branches
- Added `_` translation in MongoDB and libaccess; fixed broken lambda
missing `value` param in libaccess
- Renamed SurnameMappingGramplet.grp.py → .gpr.py (typo — file was
never loaded by Gramps, which only recognizes .gpr.py)
- Fixed `print(...).format(...)` missing close paren in QueryQuickview
- Dropped invalid `parent=self.uistate.window` at module level in
lxmlGramplet (no self exists outside instance methods)
- Fixed `displayer.display(...)` → `name_displayer.display(...)` in
QuiltView (matches the import alias)
- Initialized `tmg_dataset = None` in TMGimporter so ruff can prove
the `locals()` guard isn't needed
- Fixed `LOG.warn("ignored: " + data)` → `+ line` in JSONImport
(wrong var — would crash if it ever hit that branch)
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 2fb28b6 commit 7941194
38 files changed
Lines changed: 137 additions & 43 deletions
File tree
- .github/workflows
- AnniversariesGramplet
- po
- ArchiveAssist/po
- AttachSourceTool
- CombinedView
- DenominoViso
- DescendantBooks
- DescendantsLines
- DynamicWeb
- EditExifMetadata
- Form
- GrampsChat/po
- GrampsWebSync
- GrampyScript/po
- JSON
- LifeLineChartView
- LinesOfDescendency
- MongoDB
- PersonEverything
- PlaceUpdate
- PostgreSQLEnhanced
- Query
- QuiltView
- RelID
- SourceIndex
- SourceReferences
- SurnameMappingGramplet
- TMGimporter
- TimelinePedigreeView
- libaccess
- lxml
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| |||
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
129 | | - | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
| 132 | + | |
132 | 133 | | |
133 | | - | |
134 | | - | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
135 | 139 | | |
136 | 140 | | |
137 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
213 | | - | |
214 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
0 commit comments