feat: hand OPEN_EDX_FILTERS_CONFIG enterpise injection ownership to enterprise/consent plugin#281
Merged
Merged
Conversation
pwnage101
force-pushed
the
pwnage101/ENT-11830-edx
branch
from
afaa7a6 to
2f437fe
Compare
…nterprise/consent plugin The goal of this migrated logic is to be able to inject enterprise-specific pipeline steps while preserving any operator-defined keys and pipeline steps. It is being migrated into the enterprise/consent plugins to better compartmentalize enterprise-specific logic and keep enterprise code paths outside of the platform. ENT-11830 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pwnage101
force-pushed
the
pwnage101/ENT-11830-edx
branch
from
2f437fe to
2a930b2
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates enterprise-specific OPEN_EDX_FILTERS_CONFIG defaults/merge behavior out of edx-platform settings and into the enterprise/consent plugin (via an edx-enterprise bump), to better isolate enterprise logic while still allowing operator configuration via YAML.
Changes:
- Bump
edx-enterprisedependency from8.0.12to8.0.14across constraints and requirement sets. - Remove enterprise-owned
OPEN_EDX_FILTERS_CONFIGdefaults fromlms/envs/common.py. - Remove bespoke YAML merge/post-processing for
OPEN_EDX_FILTERS_CONFIGinlms/envs/production.py(so YAML can define it directly, and plugins can inject/merge later).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements/edx/testing.txt | Bumps edx-enterprise to pick up migrated plugin logic in test requirements. |
| requirements/edx/doc.txt | Bumps edx-enterprise in docs requirements set. |
| requirements/edx/development.txt | Bumps edx-enterprise in dev requirements set. |
| requirements/edx/base.txt | Bumps edx-enterprise in base requirements set. |
| requirements/constraints.txt | Updates pinned edx-enterprise constraint to the new version. |
| lms/envs/production.py | Removes platform-side OPEN_EDX_FILTERS_CONFIG YAML merge logic and no longer treats it as a “special” YAML key. |
| lms/envs/common.py | Removes platform-side OPEN_EDX_FILTERS_CONFIG default and its setting documentation block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kiram15
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this migrated logic is to be able to inject enterprise-specific pipeline steps while preserving any operator-defined keys and pipeline steps.
It is being migrated into the enterprise/consent plugins to better compartmentalize enterprise-specific logic and keep enterprise code paths outside of the platform.
ENT-11830