feat: remove NoticesWrapper and add local translations merge to release-ulmo#8
Merged
Merged
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…9.3 (openedx#739) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edx#740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enedx#744) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…extra repositories (openedx#752)
…extra repositories (openedx#752)
There was a problem hiding this comment.
Pull request overview
This PR removes the NoticesWrapper feature and synchronizes translation-related changes from the upstream repository. The NoticesWrapper component, which integrated with the platform-plugin-notices plugin to redirect users with unacknowledged notices, is being completely removed along with its configuration flag. The PR also includes minor dependency updates and Makefile improvements for translation extensibility.
- Removes NoticesWrapper component and all associated code (component, hooks, API, tests, messages)
- Removes ENABLE_NOTICES configuration from all environment files and config
- Updates frontend dependencies (@edx/frontend-component-header, react-router-dom, and transitive dependencies)
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.jsx | Removes NoticesWrapper import and unwraps Routes from NoticesWrapper component |
| src/index.test.jsx | Removes jest.mock for NoticesWrapper component |
| src/test/app.test.jsx | Removes jest.mock for NoticesWrapper component |
| src/config/index.js | Removes ENABLE_NOTICES configuration property |
| src/components/NoticesWrapper/*.js(x) | Deletes entire NoticesWrapper component directory (index, hooks, API, messages, tests) |
| package.json | Updates @edx/frontend-component-header from 6.6.0 to 8.0.0, react-router-dom from 6.30.1 to 6.30.2 |
| package-lock.json | Synchronizes lock file with package.json updates and transitive dependencies |
| example.env.config.js | Removes ENABLE_NOTICES environment variable |
| .env, .env.development, .env.test | Removes ENABLE_NOTICES environment variable from all env files |
| Makefile | Adds ATLAS_EXTRA_SOURCES, ATLAS_EXTRA_INTL_IMPORTS, and ATLAS_OPTIONS variables for translation extensibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
00e7cf5 to
67f0ddf
Compare
deborahgu
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs openedx#752
This includes the removal of the
NoticesWrapperin Learner Dashboard. See the original PR and the corresponding issue.This also includes the addition of the ability to configure local translations.