Skip to content

feat: remove NoticesWrapper and add local translations merge to release-ulmo#8

Merged
MaxFrank13 merged 19 commits into
release-ulmofrom
mfrank/sync-local-translations
Dec 11, 2025
Merged

feat: remove NoticesWrapper and add local translations merge to release-ulmo#8
MaxFrank13 merged 19 commits into
release-ulmofrom
mfrank/sync-local-translations

Conversation

@MaxFrank13
Copy link
Copy Markdown
Member

@MaxFrank13 MaxFrank13 commented Dec 5, 2025

Syncs openedx#752

This includes the removal of the NoticesWrapper in Learner Dashboard. See the original PR and the corresponding issue.

This also includes the addition of the ability to configure local translations.

feanil and others added 18 commits October 15, 2025 10:10
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…9.3 (openedx#739)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edx#740)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enedx#744)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 5, 2025 21:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the NoticesWrapper feature and synchronizes translation-related changes from the upstream repository. The NoticesWrapper component, which integrated with the platform-plugin-notices plugin to redirect users with unacknowledged notices, is being completely removed along with its configuration flag. The PR also includes minor dependency updates and Makefile improvements for translation extensibility.

  • Removes NoticesWrapper component and all associated code (component, hooks, API, tests, messages)
  • Removes ENABLE_NOTICES configuration from all environment files and config
  • Updates frontend dependencies (@edx/frontend-component-header, react-router-dom, and transitive dependencies)

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/index.jsx Removes NoticesWrapper import and unwraps Routes from NoticesWrapper component
src/index.test.jsx Removes jest.mock for NoticesWrapper component
src/test/app.test.jsx Removes jest.mock for NoticesWrapper component
src/config/index.js Removes ENABLE_NOTICES configuration property
src/components/NoticesWrapper/*.js(x) Deletes entire NoticesWrapper component directory (index, hooks, API, messages, tests)
package.json Updates @edx/frontend-component-header from 6.6.0 to 8.0.0, react-router-dom from 6.30.1 to 6.30.2
package-lock.json Synchronizes lock file with package.json updates and transitive dependencies
example.env.config.js Removes ENABLE_NOTICES environment variable
.env, .env.development, .env.test Removes ENABLE_NOTICES environment variable from all env files
Makefile Adds ATLAS_EXTRA_SOURCES, ATLAS_EXTRA_INTL_IMPORTS, and ATLAS_OPTIONS variables for translation extensibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MaxFrank13 MaxFrank13 force-pushed the mfrank/sync-local-translations branch from 00e7cf5 to 67f0ddf Compare December 5, 2025 21:31
@MaxFrank13 MaxFrank13 changed the title feat: sync local translations feat: remove NoticesWrapper and add local translations Dec 8, 2025
@MaxFrank13 MaxFrank13 changed the title feat: remove NoticesWrapper and add local translations feat: remove NoticesWrapper and add local translations merge to release-ulmo Dec 8, 2025
@MaxFrank13 MaxFrank13 merged commit ef81ef0 into release-ulmo Dec 11, 2025
2 of 3 checks passed
@MaxFrank13 MaxFrank13 deleted the mfrank/sync-local-translations branch December 11, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants