fix: env variables fetching issue for translations#9
Merged
Conversation
MaxFrank13
approved these changes
Dec 17, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with fetching environment variables for translation configuration by changing the Makefile variable assignment operator from = to ?= for three ATLAS-related variables. This allows these variables to be overridden from environment variables or the command line, enabling external configuration (e.g., from edx-internal) as intended by the existing comment in the Makefile.
- Changes variable assignment operator to allow environment variable overrides for ATLAS translation configuration
- Affects three variables: ATLAS_EXTRA_SOURCES, ATLAS_EXTRA_INTL_IMPORTS, and ATLAS_OPTIONS
- Aligns implementation with the existing comment stating these variables can be "defined in edx-internal if needed"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.