feat: update plugin slot ids#661
Open
MaxFrank13 wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
idAliasesprop to each PluginSlot which holds the old ID in an array. Theidprop has been set to an id that conforms to the ADR set in frontend-plugin-framework: https://github.com/openedx/frontend-plugin-framework/blob/master/docs/decisions/0003-slot-naming-and-life-cycle.rstThe old ID for each slot can still be used as long as the
idAliasesfeature is available in FPF. The public, open-source MFEs have been updated already for this. Example PR in Learner Dashboard: openedx/frontend-app-learner-dashboard#608Additionally, the webpack.dev.config.js file has been modified slightly to allow for easier local development. This small change will enable developers to simply
npm startand it will spin up the example app.